search

blockchainprojects / bitshares-ui

Graphical User Interface for BitShares Blockchain
https://wallet.bitshares.org
MIT License
0 stars 1 forks source link

#2960 Refine wallet merchant protocol #172

Closed VerevkinAlexander closed 5 years ago

VerevkinAlexander commented 5 years ago

General

Closes #169

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

Testing

The branch has been tested on the following browsers (desktop and mobile view)

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

image image

sschiessl-bcp commented 5 years ago

For invoice pay, if there is no data present in the link did you add the possibility to scan/enter data in the Pay panel?

VerevkinAlexander commented 5 years ago

For invoice pay, if there is no data present in the link did you add the possibility to scan/enter data in the Pay panel?

There is no way to enter data. I can add some input for invoice string instead of error message when the data string is empty. What do you think?

sschiessl-bcp commented 5 years ago

There is no way to enter data

Absolutely correct. That is why in the specification of the task we have 3 ii. image

To clarify: if data in address present, use that. if not present, show the enter / scan possibility.

I imagine somehting like shown in Withdraw modal (see the camera icon) image

If that is hardcoded within the WithdrawModal please create a new ScanOrEnterText component

sschiessl-bcp commented 5 years ago

This ready for re-review?

VerevkinAlexander commented 5 years ago

@sschiessl-bcp, yes. But I think responsive design requires some work, especially for phones. It can take 1-2 hours.

sschiessl-bcp commented 5 years ago

We will do responsive in separate issue, dont worry for now

sschiessl-bcp commented 5 years ago

Please change:

VerevkinAlexander commented 5 years ago

is payment QR code the correct one like indicated in the issue?

image

bitshares:operation/transfer?to=&from=&asset=&amount=<11000>&memo=<Invoice #1234>

image

sschiessl-bcp commented 5 years ago

Example to transfer 100 TEST from bitshares account sschiessl to bitshares account test

bitshares:operation/transfer?to=test&from=sschiessl&asset=TEST&amount=100

If there is a memo specified

bitshares:operation/transfer?to=test&from=sschiessl&asset=TEST&amount=100&memo=Some memo

VerevkinAlexander commented 5 years ago

Example to transfer 100 TEST from bitshares account sschiessl to bitshares account test

bitshares:operation/transfer?to=test&from=sschiessl&asset=TEST&amount=100

If there is a memo specified

bitshares:operation/transfer?to=test&from=sschiessl&asset=TEST&amount=100&memo=Some memo

thanks

VerevkinAlexander commented 5 years ago

fixed, plz check

sschiessl-bcp commented 5 years ago

Pay

Request

VerevkinAlexander commented 5 years ago

Pay

  • if I scan invalid code twice, view breaks
  • show error message if code invalid
  • I was not able to scan a previously created invoice string, e.g. 8h1jWsPMZ2uEX4TYZesabDNfGbDzaJf4YQ3yPSG1AbVytg7cDkyAdzsKvy8qz1uaLCgj1AkhUsidaT9dazLw42GAx5jscXGYbwRV2EdkHoQzcaNoccwq231UcA7d6aa6K73GPS2uWXDuDVN5JU4c8WHWTA2wF7ghJsfB8zemAcurUwwh17pQXS72FBL7pMmnmtZciJP91

Request

  • when adding 2 items, then removing one, the plus button does not reappear
  • when user submits, show created string with a readonly textarea or field below to allow copy, with a copy button on the right side

fixed

sschiessl-bcp commented 5 years ago

Accepted