blockchainprojects / bitshares-ui

Graphical User Interface for BitShares Blockchain
https://wallet.bitshares.org
MIT License
0 stars 1 forks source link

#3040 adapt error messages to new json rpc of bitshares core 3.2.0 #189

Closed Metizik closed 5 years ago

Metizik commented 5 years ago

General

Closes #185 I added the error code and error details in the Transaction Confirm dialog, if available. I haven't tested the new code with a node that uses the old version of the error, but I added the code in such a way as not to change the logic of displaying the old error. I tested the new code by executing several failed transactions. I also made a PR in bitsharesjs to add an error detail pass to the UI.

TransactionConfirm1

TransactionConfirm2

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

Testing

The branch has been tested on the following browsers (desktop and mobile view)

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

Please provide screenshots/licecap of your changes below

Metizik commented 5 years ago

I did a little refactoring and beautified the error displaying

TransactionConfirm3

sschiessl-bcp commented 5 years ago

Forwarded