search

blockchainprojects / bitshares-ui

Graphical User Interface for BitShares Blockchain
https://wallet.bitshares.org
MIT License
0 stars 1 forks source link

2244 wallet merchant protocol not work #97

Closed VerevkinAlexander closed 5 years ago

VerevkinAlexander commented 5 years ago

General

Closes #94 I`ve added invoice component and fixed issues with AccountInfo and added routs to App component

sschiessl-bcp commented 5 years ago

Did you test this after restoring? And if so, how?

If I open this page I see the old page image

The button does not enable itself even after loggin in (it should be possible to always create the pdf, furthermore clicking on the QR icon on the left side does not work. Please have a look

VerevkinAlexander commented 5 years ago

Did you test this after restoring? And if so, how?

I have tested it. I created the invoice and pay it using my testnet accounts.

The button does not enable itself even after loggin in

It will be enabled after successfully created payment.

clicking on the QR icon on the left side does not work

How it should works?

If I open this page I see the old page

Please give me your vision of how it should looks

sschiessl-bcp commented 5 years ago

https://github.com/blockchainprojects/bitshares-ui/issues/94#issuecomment-487545347

Does this work for you locally?

VerevkinAlexander commented 5 years ago

#94 (comment)

Does this work for you locally?

yes

VerevkinAlexander commented 5 years ago

@sschiessl-bcp Please review it.

sschiessl-bcp commented 5 years ago

You need to seriously start checking if you are checking in reformatting only files (always revert them and exclude in the commit if you see one). This caused the conflict that present. image

Will resolve now

sschiessl-bcp commented 5 years ago

This PR contains reformatting only changes for

This is not acceptable. Please create a new feature branch off of latest develop and include the actual changes for the issue and create a new PR