Refactor `Element` classes with key constants - Githubissues

blockchainworkbench / workbench-ui

UI of blockchain workbench landing page

0 stars 0 forks source link

Refactor `Element` classes with key constants #56

Open severus-sn4pe opened 5 years ago

severus-sn4pe commented 5 years ago

quick thought: can't the key (like h1, exercise, img, ...) be a constant in all Element classes? Then we can create an Element interface which all element should implement, with a function getTag()

Should not be fixed in this pr but it could make it more standardized

Originally posted by @thibmeu in https://github.com/blockchainworkbench/workbench-ui/pull/55

affects src/components/page/elements/index.js