Another cleanup of BTC rover - Githubissues

blockcollider / bcnode

Mining node and rovers for the five genesis chains of Block Collider.

https://www.blockcollider.org

MIT License

45 stars 23 forks source link

Another cleanup of BTC rover #241

Closed akloboucnik closed 6 years ago

akloboucnik commented 6 years ago

do not track discovered / satoshi peers separately - getter now counts from network.peers structure
remove unused fields from network.state structure, add flow type
rename network.setState -> network.updateBestHeight to better reflect what the method actually does
network.bestHeight now is guaranteed to be monotonically increasing
let network.pool handle disconnects internally, just remove the disconnected peer from network._state.peers

General

[x] Did you add appropriate logs for new code? In proper levels?
[x] Did you remove all console.logs / println!()s used for debugging (or replaced with log.debug() / trace!() respectively)?

Other

[x] Did you run yarn run dist locally without errors?
[x] Did you try to run the node with all subsystems (UI+WS, P2P node, rovers, persistence)?
[x] Did you try to rebase on top of base branch?
[x] Have you squashed all "fix typo"-kind and fixup! commits?