search

blockfrost / blockfrost-go

Golang SDK for Blockfrost.io
Apache License 2.0
23 stars 9 forks source link

Code review #22

Closed kenriortega closed 2 years ago

kenriortega commented 2 years ago

Solve this https://github.com/blockfrost/blockfrost-go/pull/18#discussion_r712162575 for metadata, pool, account endpoints Solve this https://github.com/blockfrost/blockfrost-go/pull/18#discussion_r712171385 for metadata, pool, account endpoints

For this review https://github.com/blockfrost/blockfrost-go/pull/18#discussion_r712180403 , only I used httptest, in the future I try to migrate step by step to testing on live server and generating/updating golden.

Solve this https://github.com/blockfrost/blockfrost-go/pull/18#discussion_r712190387 

// Was changed this 
JSONMetadata map[string]interface{} `json:"json_metadata,omitempty"`
// for this
JSONMetadata interface{} `json:"json_metadata,omitempty"`
// Because when i used the interface data type allow more options than map[string]interface{}