search

blockfrost / blockfrost-js

Node.js SDK for the Blockfrost.io API.
https://blockfrost.io
Apache License 2.0
105 stars 24 forks source link

Remove axios #121

Closed vladimirvolek closed 2 years ago

vladimirvolek commented 3 years ago

Use https://www.npmjs.com/package/got

karltaylor commented 3 years ago

Use https://www.npmjs.com/package/got

I'm just curious @vladimirvolek, why?

vladimirvolek commented 3 years ago

Use https://www.npmjs.com/package/got

I'm just curious @vladimirvolek, why?

yey hello!

The reason is that I don't like this error handling https://github.com/blockfrost/blockfrost-js/blob/master/src/utils/index.ts#L76 Also, we can remove one dependency retry-axios (https://www.npmjs.com/package/got#retry)

technoY2K commented 2 years ago

I'm also now curious as to why @vladimirvolek. What is it about the error do you dislike?