Closed eduramme closed 3 months ago
Seems like you have conflicts to solve
@eduramme the changes inside this PR look pretty much like the ones done in https://github.com/blockful-io/external-resolver-dapp/pull/118
Is this PR needed?
In case this PR is needed as well as the other one is, I have added a number of feedbacks in there regarding these changes, can you please make sure those are applied here as well?
@eduramme the changes inside this PR look pretty much like the ones done in #118
Is this PR needed?
In case this PR is needed as well as the other one is, I have added a number of feedbacks in there regarding these changes, can you please make sure those are applied here as well?
This branch is being used as the base branch. It should be merged to apply the changes made after the code review. Therefore, there's no need to commit the same changes from the other PR in this one, as both will be merged eventually.
@eduramme and what about the updates done in the other PR? I am not sure how you will keep both up to date without merging non-approved code
@eduramme and what about the updates done in the other PR? I am not sure how you will keep both up to date without merging non-approved code
I can merge https://github.com/blockful-io/external-resolver-dapp/pull/118 into this branch, no problem
@FrancoAguzzi done
@eduramme great! Thanks
Now let's merge PR 118 first and later on I review this PR 👍🏼
The latest updates on your projects. Learn more about Vercel for Git ↗︎