blockful-io / external-resolver-dapp

https://external-resolver-dapp.vercel.app
2 stars 2 forks source link

Show not owned domains #115

Closed eduramme closed 3 months ago

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nameful ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 1:37am
qa-nameful ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 1:37am
lgahdl commented 4 months ago

Seems like you have conflicts to solve

FrancoAguzzi commented 3 months ago

@eduramme the changes inside this PR look pretty much like the ones done in https://github.com/blockful-io/external-resolver-dapp/pull/118

Is this PR needed?

In case this PR is needed as well as the other one is, I have added a number of feedbacks in there regarding these changes, can you please make sure those are applied here as well?

eduramme commented 3 months ago

@eduramme the changes inside this PR look pretty much like the ones done in #118

Is this PR needed?

In case this PR is needed as well as the other one is, I have added a number of feedbacks in there regarding these changes, can you please make sure those are applied here as well?

This branch is being used as the base branch. It should be merged to apply the changes made after the code review. Therefore, there's no need to commit the same changes from the other PR in this one, as both will be merged eventually.

FrancoAguzzi commented 3 months ago

@eduramme and what about the updates done in the other PR? I am not sure how you will keep both up to date without merging non-approved code

eduramme commented 3 months ago

@eduramme and what about the updates done in the other PR? I am not sure how you will keep both up to date without merging non-approved code

I can merge https://github.com/blockful-io/external-resolver-dapp/pull/118 into this branch, no problem

eduramme commented 3 months ago

@FrancoAguzzi done

FrancoAguzzi commented 3 months ago

@eduramme great! Thanks

Now let's merge PR 118 first and later on I review this PR 👍🏼