search

blockful-io / external-resolver-dapp

https://external-resolver-dapp.vercel.app
2 stars 2 forks source link

feat: edit record access control #146

Closed pikonha closed 2 months ago

pikonha commented 3 months ago

Bug Report

CTA is being displayed for unauthorized user

If user is not manager, he/she should not be able to edit records.

Image

Current behavior

The edit record CTA is shown even for a visitor that is not the domain's manager.

Expected behavior

The edit record CTA should only be shown for a visitor that is the domain's manager.

Steps to reproduce

Visit Manage Domain page

Proposed solution

Create a conditional to display the Edit CTA based on the comparison of authed user and domain's manager.

pikonha commented 3 months ago

this is duplicated by #125

pikonha commented 2 months ago

looks good to me 🔥