This project aims to scale the Ethereum Name Service (ENS) by consolidating existing patterns and proofs of concept into a unified and production-ready codebase.
[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Description
The flow of fetching the primary name involves calling the Universal Resolver which relies on the resolver(node, encodedFunc) function of the domain's resolver.
The current implementation was causing the resolve with name(bytes32) function encoded as an argument to revert as an OffchainLookup which is supported by the Universal Resolver. However, since the setName cannot be handled off-chain because the ENS contracts don't support the EIP-5559 yet, we had to implement both the setName and name function on-chain. Therefore, we should not revert with OffchainLookup.
Related Issue
149
Changes
[ ] New feature implementation
[X] Bug fix
[ ] Code refactoring
[ ] Documentation update
[ ] Other (please specify)
Changes to Core Features:
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[X] Have you successfully run tests with your changes locally?
DB Resolver: set primary name
All Submissions:
Description
The flow of fetching the primary name involves calling the Universal Resolver which relies on the
resolver(node, encodedFunc)
function of the domain's resolver.The current implementation was causing the
resolve
withname(bytes32)
function encoded as an argument to revert as anOffchainLookup
which is supported by theUniversal Resolver
. However, since thesetName
cannot be handled off-chain because the ENS contracts don't support the EIP-5559 yet, we had to implement both thesetName
andname
function on-chain. Therefore, we should not revert withOffchainLookup
.Related Issue
149
Changes
Changes to Core Features:
Additional Notes