blockful-io / external-resolver

This project aims to scale the Ethereum Name Service (ENS) by consolidating existing patterns and proofs of concept into a unified and production-ready codebase.

MIT License

15 stars 3 forks source link

Metadata Empty Records #202

Closed pikonha closed 2 months ago

pikonha commented 2 months ago

Metadata Empty Records

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Avoid fetching empty records on the Metadata API.

For text records: value is empty
For address values: address is empty OR 0x or 0x0000... (zero address)

It also blocks setting the graphqlUrl for non-owners.

Related Issue

182

Changes

[ ] New feature implementation
[X] Bug fix
[ ] Code refactoring
[ ] Documentation update
[ ] Other (please specify)

Changes to Core Features:

[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[X] Have you written new tests for your core changes, as applicable?
[X] Have you successfully run tests with your changes locally?