blockful-io / external-resolver

This project aims to scale the Ethereum Name Service (ENS) by consolidating existing patterns and proofs of concept into a unified and production-ready codebase.

MIT License

15 stars 3 forks source link

Wildcard Writing v0.2 #239

Open pikonha opened 2 weeks ago

pikonha commented 2 weeks ago

Wildcard Writing v0.2

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The feedback gathered from the community has been applied to our interface resulting in some minor changes:

Removal of the OffchainMulticallable
Creation of the RegisterRequest struct to avoid stack too deep errors
Addition of the token (according to the EIP-7528) and available properties to the RegisterParams struct
Addition of the OffchainTransferrable interface

Related Issue

237

233

231

Changes

[X] New feature implementation
[ ] Bug fix
[ ] Code refactoring
[ ] Documentation update
[ ] Other (please specify)

Changes to Core Features:

[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[X] Have you successfully run tests with your changes locally?

Additional Notes