feat: create a way to handle errors

blockful-io / swaplace-contracts

Swaplace is an open-source, ownerless and feeless token swap protocol

https://app.swaplace.xyz/

MIT License

33 stars 33 forks source link

feat: create a way to handle errors #141

Closed luislucena16 closed 10 months ago

luislucena16 commented 10 months ago

considering solidity updates and good semantic practices, it can be:
```
if (owner != msg.sender) revert NotAllowed();
```
helps to make error messages more verbose and simple to view code for developers or feedback to users.

0xneves commented 10 months ago

Hi @luislucena16 Referring to the identation, I think its a good idea to shorten characters in the code by removing the "{}" of the if else's, from this:

        if (swap.owner != msg.sender) {
            revert InvalidAddress(msg.sender);
        }

...to this:

        if (swap.owner != msg.sender) revert InvalidAddress(msg.sender);

luislucena16 commented 10 months ago

hey @0xneves yes exactly! it allows to handle errors more organized and with better semantics 💫

0xjoaovpsantos commented 10 months ago

Hey guys this issue is available? If so, I would like to get it

@0xneves @luislucena16

luislucena16 commented 10 months ago

hi @0xjoaovpsantos I'll take care of it!

0xneves commented 10 months ago

Counting on you, this is a fast one, let's go!

luislucena16 commented 10 months ago

done! PR: https://github.com/blockful-io/swaplace-contracts/pull/157

0xneves commented 10 months ago

Could you speed up this resolution @luislucena16? Since it is blocking issue #104 from developing. Thank you

luislucena16 commented 10 months ago

done! waiting for your approval