feat: initialize foundry repo for Swaplace-CCIP

blockful-io / swaplace-contracts

Swaplace is an open-source, ownerless and feeless token swap protocol

https://app.swaplace.xyz/

MIT License

33 stars 33 forks source link

feat: initialize foundry repo for Swaplace-CCIP #142

Closed 0xneves closed 8 months ago

0xneves commented 10 months ago

Feature Request

Initialize the Foundry repository in this branch

Describe the Feature Request

Download Foundry in the repository
Add OpenZeppelin to the remappings
Migrate the contracts and scripts into their respective folders

Describe Preferred Solution

Only setting up the repo and migrating the files is necessary for this issue, among setting OpenZeppelin and RPC configurations.

Additional Context

I'll create a lot of issues on top of this resolution. CCIP will be a medium<>high difficulty level and will count for this incentives cycle. The sooner this is completed the faster we can release the issues.

0xneves commented 10 months ago

Will move this issue to the ccip-swaplace repo later

0xjoaovpsantos commented 10 months ago

Hey @0xneves , this issue is finished with this repo right? https://github.com/blockful-io/ccip

0xneves commented 10 months ago

Noooo @0xjoaovpsantos , that repo is Solidity and Scripts with Hardhat, we need to instance a new branch to prepare the Foundry setup instead of Hardhat

luislucena16 commented 10 months ago

hey @0xneves this was the issue I created, it is related to this: https://github.com/blockful-io/swaplace-contracts/issues/140

0xjoaovpsantos commented 10 months ago

If I can get this issue to work @0xneves :)

0xneves commented 10 months ago

hey @0xneves this was the issue I created, it is related to this: #140

@luislucena16 as explained in the issue you referred where I replied:

As explained in https://github.com/blockful-io/swaplace-contracts/issues/138 , we are using Hardhat for easy onboarding on this repository and Echidna for fuzz testing. I'd love to implement the foundry bullet points you quoted into the ccip repository (Will probably have a new name soon).

You proposed foundry for Swaplace, we will not use Foundry for Swaplace. But for CCIP, as I mentioned in Discord and other issues, it will use Foundry.

0xneves commented 10 months ago

ccip tasks will be more heavy and will extend over February and March

luislucena16 commented 10 months ago

are the incentives also different?

0xneves commented 10 months ago

Please help me @luislucena16 @0xjoaovpsantos

There are multiple ways to do this task, as the repo configurations could vary.

I don't want to assign this task to someone due to the diversity of boilerplates that are possible.

Shall we do it like this:

[ ] submit your best Foundry Boilerplate and adapt https://github.com/blockful-io/swaplace-ccip into it. I will review how lightweight it is, and the overall usability, among any other features you find interesting. We will debate and implement the best boilerplate for starters.

I think you can start by submitting a PR for this issue with your best boilerplate for Foundry.

Help us achieve this repository by January 1st week. And I'll start decentralize the ccip contract issues for the community.

0xneves commented 10 months ago

are the incentives also different?

Not at first sight, it will depend on the grants we acquire in the process. CCIP will charge fees and so is Blockful. Since its a monetized product, we will probably have better incentives as the knowledge required to build on top of it will also be higher.

0xneves commented 10 months ago

Is any of you interested in moving on with this task @0xjoaovpsantos and @luislucena16 ?

0xjoaovpsantos commented 10 months ago

Yeah @0xneves !!! In this week i'll upload a proposal :)

0xneves commented 9 months ago

Yeah @0xneves !!! In this week i'll upload a proposal :)

I'm excited to see what you have been doing!

The tests are a bonus, you don't have to push it too further, only the repo configuration and compilation are the most sensitive part for this task!

0xneves commented 9 months ago

Let me know if you need anything @0xjoaovpsantos !! I'm actively carving for this issue, as it will kickstart all the next issues for the swaplace-ccip 🤟

0xneves commented 9 months ago

I updated the issue to be more concise and help on the mitigation of more issues for community

0xjoaovpsantos commented 9 months ago

@0xneves Sorry man one last question, is it to integrate the foundry with the hardhat or remove the hardhat and install the foundry? :)

0xneves commented 9 months ago

@0xjoaovpsantos It's to remove the hardhat, all-win foundry.

0xneves commented 8 months ago

Hey @0xjoaovpsantos @luislucena16 I've moved this to be a hot task following my last request for change comment in here

This is past midnight from being ready. I'll be assuming this task myself in case it's not done by this Monday (12).

0xjoaovpsantos commented 8 months ago

Fixed it sir! -> https://github.com/blockful-io/swaplace-ccip/pull/7#issuecomment-1937943722

@0xneves