blockful-io / swaplace-contracts

Swaplace is an open-source, ownerless and feeless token swap protocol
https://app.swaplace.xyz/
MIT License
33 stars 33 forks source link

feat: [ISSUE-119] feat: adding a receiver as parameter in the accept swap function #149

Closed 0xjoaovpsantos closed 8 months ago

0xjoaovpsantos commented 8 months ago

This PR close #119

Proposal in the issue:

Plus:

Tests:

Example transaction: https://sepolia.etherscan.io/tx/0xf9b626c70167d25319884791913857ce748eee1696cb8c35d932ae9ef267f193

0xjoaovpsantos commented 8 months ago

I'm fixing the conflicts

0xjoaovpsantos commented 8 months ago

Fixed all conflicts in the PR with main branch and errors in the unit tests :)

0xjoaovpsantos commented 8 months ago

Okay, now it's ready to review rs

0xjoaovpsantos commented 8 months ago

@0xneves

0xjoaovpsantos commented 8 months ago

Fixed the PR conflicts :)

0xneves commented 8 months ago

@0xjoaovpsantos Happy New Year, how is this task going? We just need minor changes to approve this!

0xjoaovpsantos commented 8 months ago

HEEEEEEEY @0xneves HAPPY NEW YEAR MANNN

Sorry for the delay, I fixed this detail :)