Closed luislucena16 closed 8 months ago
@luislucena16
The onlyOwner modifier is standard when dealing with ownership over contracts. Although Swaplace is not meant to have owners or Ownership features.
The swap.owner
exists because swaps can be built by anyone, but can only be created if the owner proves to be msg.sender.
Whereas using OnlyOwner is not meant to verify swap.owner
, it would be better with a modifier such as OnlySender(swap.owner)
. Although this would create more complexity for legibility, and require more gas.
Closing this issue because it does not improve the overall contract.
I understand! the owner's approach is different from what I thought, thanks for the clarification!
onlyOwner
modifier with theOwnable
library directly into the function, ie:remove this:
using this:
and improve the logic of the owner related function!
@0xneves please assign this to me!