blockful-io / swaplace-contracts

Swaplace is an open-source, ownerless and feeless token swap protocol
https://app.swaplace.xyz/
MIT License
33 stars 33 forks source link

refactor: Adding a test case for testing parseData() and packData() #177

Closed blackbeard002 closed 8 months ago

blackbeard002 commented 8 months ago

Refactor Request

Describe the Refactor Request

Currently all the tests in TestSwaplace have the allowed as zero address. So the packing and parsing of non zero addresses aren't checked anywhere in the entire test suite.

Describe Preferred Solution

Write a test case to test parseData() and packData() where the allowed is a non-zero address.

Describe Alternatives

Related Code

Additional Context