refactor: Set the value of `config` as zero directly instead of packing `allowed` and `expiry` in the `acceptSwap()`.

blockful-io / swaplace-contracts

Swaplace is an open-source, ownerless and feeless token swap protocol

https://app.swaplace.xyz/

MIT License

33 stars 33 forks source link

refactor: Set the value of `config` as zero directly instead of packing `allowed` and `expiry` in the `acceptSwap()`. #184

Closed blackbeard002 closed 7 months ago

blackbeard002 commented 7 months ago

Refactor Request

Describe the Refactor Request

Setting the value of config as zero directly instead of packing allowed and expiry in the acceptSwap() thereby negating the call for packData() to save some gas.

Describe Preferred Solution

_swaps[swapId].config = 0

blockful-io / swaplace-contracts

refactor: Set the value of `config` as zero directly instead of packing `allowed` and `expiry` in the `acceptSwap()`. #184

Refactor Request

Describe the Refactor Request

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context