search

blockful-io / swaplace-contracts

Swaplace is an open-source, ownerless and feeless token swap protocol
https://app.swaplace.xyz/
MIT License
33 stars 33 forks source link

epic: native ether and ERC1155 swaps #204

Closed 0xneves closed 3 months ago

0xneves commented 4 months ago

Feature Request

Describe the Feature Request

The revision branch is out and needs a few tests to guarantee the contract is working correctly. The main subjects that need to be addressed in this epic are:

Please ping me on GitHub so I can address an issue to you in case you're interested. One at a time, please! Please ping me on Discord for questions regarding the issues below. Happy coding.

Describe Preferred Solution

TARGET BRANCH: REVISION

Additional Context

Check how the native ether transfer works

blackbeard002 commented 3 months ago

Hey @0xneves will I be getting assigned for this as well since I closed it all? :eyes: :joy:

0xneves commented 3 months ago

Hey @0xneves will I be getting assigned for this as well since I closed it all? 👀 😂

This is not an issue, but rather an epic, only means for tracking and managements, thus why I'm assigned

blackbeard002 commented 3 months ago

Hey @0xneves will I be getting assigned for this as well since I closed it all? 👀 😂

This is not an issue, but rather an epic, only means for tracking and managements, thus why I'm assigned

Yeah yeah I was just kidding 😅