fix: searched ens name are not retrieving data

blockful-io / swaplace-dapp

Swaplace is an, Open-source, Ownerless and Feeless Token Swap Protocol

https://app.swaplace.xyz

MIT License

13 stars 18 forks source link

fix: searched ens name are not retrieving data #320

Open heronlancellot opened 5 months ago

heronlancellot commented 5 months ago

Bug Report

Swaplace version

230827e

Current behavior

wrapper.ens.eth

Expected behavior

Expected the right user name ens address & retrieve the right data from the user.

Steps to reproduce

Search an ens name and check if the tokens are the same, also in the OfferSummary are not the same name.

Related code

OfferSummary.tsx SearchBar.tsx

0xneves commented 5 months ago

I think this error is related to the end point we are using, it is public and free so it might not be 100% synced with the correct ens state

0xneves commented 4 months ago

Try to contact the dev at https://ensdata.net/

heronlancellot commented 4 months ago

@0xneves I'm checking this issue and it looks like we are using the lib "web3-eth-ens" import { ENS } from "web3-eth-ens" to retrieve the ens name address from the user.

I opened this draft PR to show the difference between the getOwner & getAddress.. Let's see it.

heronlancellot commented 4 months ago

Closed by #384

heronlancellot commented 4 months ago

Reopened the issue because the solution in #384 still not working.

heronlancellot commented 2 weeks ago

Because of this problem we're creating an new issue to remove the .ens from the dApp to works fine without any difference-name-surprise