blockkeeper / blockkeeper-frontend-web

blockkeeper.io - Your blockchain book keeping app
GNU General Public License v3.0
25 stars 12 forks source link

Error handling invalid blockexplorer address #17

Closed yeahoffline closed 6 years ago

yeahoffline commented 7 years ago

https://github.com/blockkeeper/blockkeeper-frontend-web/blob/master/src/logic/coin/Lib.js#L75

since the requests are batched it is not possible to monitor single address errors.

replicate error: add a invalid (btc) address. pld will be: {error: "Address asdfasdfasfafasdfasfdasfasfasfas is invalid: Address asdfasdfasfafasdfasfdasfasfasfas is of unknown size."}

d3ck-org commented 7 years ago

Forcing valid addresses makes this problem obsolet: In depth address validation should be occur when the user creates the address.

I will rework the validation in the course of xpub-key integration.