blockmason / lndr

Lending on the Blockchain
https://lndr.io/
9 stars 6 forks source link

🐛Dynamically replace SSH URLs with HTTPS URLs, only on Travis CI builds #187

Closed canterberry closed 6 years ago

canterberry commented 6 years ago

The SSH key previously in use was recently scrubbed by GitHub as part of an audit, and was no longer functional.

canterberry commented 6 years ago

Reference: https://github.com/travis-ci/travis-ci/issues/6009 Travis CI doesn't support ed25519 keys, and likely will never support them. It's been over two years since this initial report/request, and there are several other reports like it, none with outcomes that led to ed25519 support or better messaging.

canterberry commented 6 years ago

BTW, the SSH key configured in the Travis CI build under the TRAVIS_SSH_KEY environment variable belongs to the @blockmason-unprivileged GitHub user.

This PR is a short-term workaround to our inability to update git dependencies in this project to use HTTPS URLs instead of SSH URLs, due to issues with building the project without a dependency cache seeded from a previously working build.