blocknative / web3-onboard

Client library to onboard users to web3 apps
https://onboard.blocknative.com/
MIT License
830 stars 489 forks source link

Pagination on WalletConnect modal #1663

Closed Tsirov closed 1 year ago

Tsirov commented 1 year ago

Current Behavior

Using react js progect I am implementing connection to the Web3 with useWallets() hook. When I try to connect to the Web3 and the current modal form web3-onboard appear and I click witch walletConnect after aper the modal witch suggested wallets under the wallet paginations is not working (pagination is starting from 4 number and user cannot go the lowest number of page ). It is tested on iPhone 14. You can test it event in this ### https://app.compound.finance/?market=usdc-mainnet app when you thy to connect witch wallet.

Expected Behavior

No response

Steps To Reproduce

  1. Open the let's say this app https://app.compound.finance/?market=usdc-mainnet where they have [web3-onboard] implementation.
  2. Click the icon for conectting with the wallet.
  3. Choose WalletConnect. 4 See the pagination under the suggested wallets it is start from number 4

What package is effected by this issue?

@web3-onboard/react

Is this a build or a runtime issue?

Runtime

Package Version

"@web3-onboard/react": "^2.2.6"

Node Version

v16.18.0

What browsers are you seeing the problem on?

Safari

Relevant log output

No response

Anything else?

No response

Sanity Check

leightkt commented 1 year ago

@Tsirov I can see it on the site you provided, but I'm having trouble reproducing locally. Do you have a sample code you're working with?

Tsirov commented 1 year ago

demo.zip Here is the demo where can be tested.

  1. Unzip the file
  2. Go to the project and install dependencies with npm install or yearn install
  3. Start project with npm start
  4. Go to http://localhost:3000/ and click connect wallet button
  5. After in the modal window click walletconnect .
leightkt commented 1 year ago

@Tsirov can you actually provide your code in a codesandbox.io (or similar) or via link to a github repo that I can look at? Thx.

leightkt commented 1 year ago

@Tsirov also- are you using the most recent version of the web3onboard/walletconnect package- https://www.npmjs.com/package/@web3-onboard/walletconnect

leightkt commented 1 year ago

@Tsirov I was actually finally able to reproduce locally- sorry for the delay. This is actually an issue within the V1 walletconnect module, not web3onboard. Please open an issue with the walletconnect team- https://github.com/WalletConnect/web3modal

Tsirov commented 1 year ago

@leightkt Sorry about that, and thank you for the time.