blocknative / web3-onboard

Client library to onboard users to web3 apps
https://onboard.blocknative.com/
MIT License
855 stars 510 forks source link

[Ledger] Show derivation path instead of Ledger Live #1818

Open roheat opened 1 year ago

roheat commented 1 year ago

Is your request related to a problem?

I want to bump my ledger package from @2.3.2 to @2.5.1 for the WalletConnect v2 support. However, my dapp users prefer selecting the derivation path and choosing the account without having to install Ledger Live App (which introduced in 2.4.0+).

@2.3.2

Screenshot 2023-07-08 at 2 18 41 PM

@2.5.1

Screenshot 2023-07-08 at 2 23 02 PM

Feature Description

Can you introduce a key in the module options to fallback to older derivation path logic for ledger?

const ledger = ledgerModule({
  projectId: 'abc123...',
  requiredChains: [1, 137],
  ledgerLive: false // can be true by default
})

Alternative Solutions

No response

Anything else?

No response

Adamj1232 commented 1 year ago

@roheat thank you for the open issue. We will discuss with the team and get back to you. Thanks again!