blocknative / web3-onboard

Client library to onboard users to web3 apps
https://onboard.blocknative.com/
MIT License
850 stars 504 forks source link

load ledger connect kit via package instead of loader #2061

Closed Wozacosta closed 9 months ago

Wozacosta commented 9 months ago

Description

Loads @ledgerhq/connect-kit package via package manager instead of via @ledgerhq/connect-kit-loader (which is deprecated).

This latest version of @ledgerhq/connect-kit that is now imported fixes this issue: https://github.com/blocknative/web3-onboard/issues/1996

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

Tests with demo app (SDK)

socket-security[bot] commented 9 months ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ledgerhq/connect-kit@1.1.12 Transitive: environment, filesystem, unsafe +6 8.59 MB ldg-github-ci, phenry-ledger, thomas.coudray
npm/@rollup/plugin-replace@5.0.5 Transitive: environment, filesystem, unsafe +3 5.3 MB shellscape
npm/rollup@2.68.0 environment, filesystem, unsafe 0 4.78 MB lukastaegert

View full report↗︎

sirtimid commented 9 months ago

Just a question @Wozacosta why did you update v1? This should be removed all together, since @walletconnect/client v1 doesn't work anyway does it?

Adamj1232 commented 9 months ago

This has been merged and published with the latest alpha version of the ledger package. Please give it a test and confirm if it is working for you!

GrayFieth commented 9 months ago

Thank you all so much

Wozacosta commented 8 months ago

Just a question @Wozacosta why did you update v1? This should be removed all together, since @walletconnect/client v1 doesn't work anyway does it?

You're right, Ill remove it altogether in a next PR 👍