blocknative / web3-onboard

Client library to onboard users to web3 apps
https://onboard.blocknative.com/
MIT License
831 stars 491 forks source link

Add Rootstock #2077

Closed jonathansmirnoff closed 2 months ago

jonathansmirnoff commented 6 months ago

Description

Add Rootstock to web3-onboard

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

Docs Checklist

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package. To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

Tests with demo app (SDK)

socket-security[bot] commented 6 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@algolia/client-search@4.17.0 None +5 258 kB shortcuts
npm/@babel/code-frame@7.23.5 None +1 41.7 kB nicolo-ribaudo
npm/@babel/compat-data@7.23.5 None 0 64.6 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6 None +2 128 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.23.4 None 0 31.6 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5 None 0 11.7 kB nicolo-ribaudo
npm/@babel/highlight@7.23.4 None 0 18.4 kB nicolo-ribaudo
npm/@babel/parser@7.23.6 None 0 1.89 MB nicolo-ribaudo
npm/@babel/runtime@7.23.2 None 0 247 kB nicolo-ribaudo
npm/@babel/types@7.23.6 environment +1 2.44 MB nicolo-ribaudo

View full report↗︎

Adamj1232 commented 6 months ago

We are not at this point adding native chains to Web3-Onboard as dapp devs can easily add chains through the initialization object. This is in an effort to keep the modules light and performant. If you would like to discuss this further and chat about other options @mhchaudhry3

jonathansmirnoff commented 5 months ago

@Adamj1232 thanks for your response. Can we create telegram group with @mhchaudhry3?

Adamj1232 commented 2 months ago

Closing as PR has become stale without developer followup