Closed mytangying closed 4 months ago
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎
To accept the risk, merge this PR and you will not be notified again.
Alert | Package | Note | Source |
---|---|---|---|
Telemetry | npm/next@12.2.5 |
| |
Install scripts | npm/core-js-pure@3.24.1 |
| |
Protestware/Troll package | npm/es5-ext@0.10.62 |
| |
Install scripts | npm/es5-ext@0.10.62 |
| |
Install scripts | npm/esbuild@0.18.20 |
| |
Install scripts | npm/svelte-preprocess@5.0.1 |
| |
Install scripts | npm/@sveltejs/kit@1.0.0-next.589 |
| |
Install scripts | npm/esbuild@0.20.2 |
|
This package contains telemetry which tracks how it is used.
Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.
Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.
Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.
Consider that consuming this package my come along with functionality unrelated to its primary purpose.
Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.
To ignore an alert, reply with a comment starting with @SocketSecurity ignore
followed by a space separated list of ecosystem/package-name@version
specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0
or ignore all packages with @SocketSecurity ignore-all
@SocketSecurity ignore npm/next@12.2.5
@SocketSecurity ignore npm/core-js-pure@3.24.1
@SocketSecurity ignore npm/es5-ext@0.10.62
@SocketSecurity ignore npm/esbuild@0.18.20
@SocketSecurity ignore npm/svelte-preprocess@5.0.1
@SocketSecurity ignore npm/@sveltejs/kit@1.0.0-next.589
@SocketSecurity ignore npm/esbuild@0.20.2
@mytangying since StableWallet is a browser injected wallet we dont support creating a new module just to add support. Web3-Onboard injected module now support 6963 wallets which means if your wallet is EIP 6963 compatible(highly recommended) the injected module will pick it up automatically without requiring web3-onboard integration.
@mytangying the PR is looking good. Can you please bump the alpha version within the injected/package.json at the top of the file?
Can you please also verify the checks in the description of this PR and confirm all testing has been done using the internal demo (yarn && yarn dev
)?
@mytangying please merge in the latest develop and bump the versions as described in the PR when you have a moment. I tried to push on my end but your repo is locked down. I will be putting a release together in the next couple hours if you would like to make this repo into that.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/0xsequence@0.43.1, npm/@adraffy/ens-normalize@1.10.1, npm/@ampproject/remapping@2.2.1, npm/@apocentre/alias-sampling@0.5.3, npm/@arcana/auth@1.0.7, npm/@babel/code-frame@7.12.11, npm/@babel/compat-data@7.17.0, npm/@babel/core@7.23.2, npm/@babel/helper-annotate-as-pure@7.22.5, npm/@babel/helper-compilation-targets@7.22.15, npm/@babel/helper-create-class-features-plugin@7.22.15, npm/@babel/helper-define-polyfill-provider@0.3.1, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-module-imports@7.22.15, npm/@babel/helper-plugin-utils@7.16.7, npm/@babel/helper-validator-option@7.22.15, npm/@babel/parser@7.23.0, npm/@babel/plugin-syntax-jsx@7.22.5, npm/@babel/plugin-syntax-typescript@7.22.5, npm/@babel/plugin-transform-modules-commonjs@7.23.0, npm/@babel/plugin-transform-runtime@7.17.0, npm/@babel/plugin-transform-typescript@7.22.15, npm/@babel/preset-typescript@7.23.2, npm/@babel/runtime@7.16.7, npm/@babel/traverse@7.23.2, npm/@babel/types@7.23.0, npm/@bitget-wallet/web3-sdk@0.0.8, npm/@blocto/dappauth@2.1.0, npm/@blocto/sdk@0.9.1, npm/@cedelabs/providers@1.5.0, npm/@celo/base@3.2.0, npm/@celo/utils@3.2.0, npm/@chainsafe/as-sha256@0.3.1, npm/@chainsafe/persistent-merkle-tree@0.4.2, npm/@chainsafe/ssz@0.9.4, npm/@chakra-ui/accordion@1.4.12, npm/@chakra-ui/alert@1.3.7, npm/@chakra-ui/anatomy@1.3.0, npm/@chakra-ui/avatar@1.3.11, npm/@chakra-ui/breadcrumb@1.3.6, npm/@chakra-ui/button@1.5.10, npm/@chakra-ui/checkbox@1.7.1, npm/@chakra-ui/clickable@1.2.6, npm/@chakra-ui/close-button@1.2.7, npm/@chakra-ui/color-mode@2.2.0, npm/@chakra-ui/control-box@1.1.6, npm/@chakra-ui/counter@1.2.10, npm/@chakra-ui/css-reset@1.1.3, npm/@chakra-ui/editable@1.4.2, npm/@chakra-ui/focus-lock@1.2.6, npm/@chakra-ui/icon@2.0.5, npm/@chakra-ui/icons@2.1.1, npm/@chakra-ui/input@1.4.6, npm/@chakra-ui/layout@1.8.0, npm/@chakra-ui/live-region@1.1.6, npm/@chakra-ui/media-query@2.0.4, npm/@chakra-ui/menu@1.8.12, npm/@chakra-ui/modal@1.11.1, npm/@chakra-ui/number-input@1.4.7, npm/@chakra-ui/pin-input@1.7.11, npm/@chakra-ui/popover@1.11.9, npm/@chakra-ui/progress@1.2.6, npm/@chakra-ui/provider@1.7.14, npm/@chakra-ui/radio@1.5.1, npm/@chakra-ui/react-utils@1.2.3, npm/@chakra-ui/react@1.8.9, npm/@chakra-ui/theme-tools@1.3.6, npm/@chakra-ui/utils@1.10.4, npm/@coinbase/wallet-sdk@3.7.2, npm/@cosmjs/amino@0.31.0, npm/@cosmjs/crypto@0.31.3, npm/@cosmjs/encoding@0.31.3, npm/@cosmjs/math@0.31.3, npm/@cosmjs/proto-signing@0.31.0, npm/@cosmjs/utils@0.31.3, npm/@cspotcode/source-map-consumer@0.8.0, npm/@cspotcode/source-map-support@0.7.0, npm/@discoveryjs/json-ext@0.5.6, npm/@emotion/is-prop-valid@1.2.2, npm/@emotion/react@11.11.4, npm/@emotion/serialize@1.1.4, npm/@emotion/styled@11.11.5, npm/@eslint/eslintrc@0.4.3, npm/@ethereumjs/common@2.5.0, npm/@ethereumjs/rlp@4.0.0, npm/@ethereumjs/tx@3.3.2, npm/@ethereumjs/util@8.0.2, npm/@ethersproject/abi@5.7.0, npm/@ethersproject/abstract-provider@5.7.0, npm/@ethersproject/abstract-signer@5.7.0, npm/@ethersproject/address@5.7.0, npm/@ethersproject/base64@5.7.0, npm/@ethersproject/bignumber@5.7.0, npm/@ethersproject/bytes@5.7.0, npm/@ethersproject/constants@5.7.0, npm/@ethersproject/hash@5.7.0, npm/@ethersproject/keccak256@5.7.0, npm/@ethersproject/logger@5.7.0, npm/@ethersproject/networks@5.7.1, npm/@ethersproject/properties@5.7.0, npm/@ethersproject/rlp@5.7.0, npm/@ethersproject/signing-key@5.7.0, npm/@ethersproject/strings@5.7.0, npm/@ethersproject/transactions@5.7.0, npm/@ethersproject/web@5.7.1, npm/@findeth/abi@0.3.1, npm/@formatjs/ecma402-abstract@1.11.3, npm/@formatjs/icu-messageformat-parser@2.0.18, npm/@hapi/address@5.1.1, npm/@hapi/formula@3.0.2, npm/@hapi/hoek@11.0.2, npm/@hapi/pinpoint@2.0.1, npm/@hapi/tlds@1.0.1, npm/@humanwhocodes/config-array@0.5.0, npm/@infinitywallet/infinity-connector@1.0.6, npm/@ioredis/commands@1.2.0, npm/@jridgewell/gen-mapping@0.3.3, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/trace-mapping@0.3.19, npm/@keepkey/device-protocol@7.7.0, npm/@keystonehq/base-eth-keyring@0.6.4, npm/@keystonehq/eth-keyring@0.14.4, npm/@ledgerhq/connect-kit-loader@1.1.0, npm/@ledgerhq/connect-kit@1.1.12, npm/@lit-labs/ssr-dom-shim@1.1.0, npm/@magic-sdk/commons@4.1.0, npm/@magic-sdk/provider@28.0.2, npm/@magic-sdk/types@24.0.1, npm/@metamask/detect-provider@2.0.0, npm/@metamask/eth-json-rpc-middleware@11.0.0, npm/@metamask/eth-sig-util@5.1.0, npm/@metamask/json-rpc-engine@7.3.3, npm/@metamask/json-rpc-middleware-stream@6.0.2, npm/@metamask/object-multiplex@1.2.0, npm/@metamask/onboarding@1.0.1, npm/@metamask/providers@8.1.1, npm/@metamask/rpc-errors@6.2.1, npm/@metamask/safe-event-emitter@2.0.0, npm/@metamask/sdk-communication-layer@0.18.2, npm/@metamask/sdk-install-modal-web@0.17.0, npm/@metamask/sdk@0.18.3, npm/@metamask/utils@3.6.0, npm/@motionone/animation@10.17.0, npm/@motionone/dom@10.12.0, npm/@motionone/easing@10.17.0, npm/@motionone/generators@10.17.0, npm/@motionone/types@10.17.0, npm/@motionone/utils@10.17.0, npm/@myetherwallet/mewconnect-web-client@2.2.0-beta.16, npm/@ngraveio/bc-ur@1.1.6, npm/@niceties/logger@1.1.3, npm/@noble/curves@1.2.0, npm/@noble/ed25519@1.7.1, npm/@noble/hashes@1.3.2, npm/@noble/secp256k1@1.6.3, npm/@nothing-but/utils@0.3.2, npm/@parcel/watcher-android-arm64@2.3.0, npm/@parcel/watcher-darwin-arm64@2.3.0, npm/@parcel/watcher-darwin-x64@2.3.0, npm/@parcel/watcher-freebsd-x64@2.3.0, npm/@parcel/watcher-linux-arm-glibc@2.3.0, npm/@parcel/watcher-linux-arm64-glibc@2.3.0, npm/@parcel/watcher-linux-arm64-musl@2.3.0, npm/@parcel/watcher-linux-x64-glibc@2.3.0, npm/@parcel/watcher-linux-x64-musl@2.3.0, npm/@parcel/watcher-wasm@2.3.0, npm/@parcel/watcher-win32-arm64@2.3.0, npm/@parcel/watcher-win32-ia32@2.3.0, npm/@parcel/watcher-win32-x64@2.3.0, npm/@parcel/watcher@2.3.0, npm/@particle-network/analytics@1.0.1, npm/@particle-network/auth@1.3.1, npm/@particle-network/provider@1.3.2, npm/@portis/web3@4.0.7, npm/@protobufjs/aspromise@1.1.2, npm/@ramp-network/ramp-instant-sdk@4.0.4, npm/@rollup-extras/plugin-copy@1.2.2, npm/@rollup/plugin-json@4.1.0, npm/@rollup/plugin-node-resolve@11.2.1, npm/@rollup/plugin-replace@5.0.5, npm/@rollup/plugin-typescript@8.3.0, npm/@safe-global/safe-apps-provider@0.17.1, npm/@safe-global/safe-apps-sdk@8.0.0, npm/@shapeshiftoss/bitcoinjs-lib@5.2.0-shapeshift.2, npm/@shapeshiftoss/hdwallet-core@1.18.4, npm/@shapeshiftoss/hdwallet-keepkey-webusb@1.18.4, npm/@shapeshiftoss/hdwallet-keepkey@1.18.4, npm/@solana/web3.js@1.78.5, npm/@solid-devtools/debugger@0.22.4, npm/@solid-primitives/event-listener@2.3.0, npm/@solid-primitives/rootless@1.4.2, npm/@solid-primitives/utils@6.2.1, npm/@tanstack/query-core@4.36.1, npm/@tanstack/query-persist-client-core@4.36.1, npm/@tanstack/query-sync-storage-persister@4.36.1, npm/@tanstack/react-query-persist-client@4.36.1, npm/@tanstack/react-query@4.36.1, npm/@toruslabs/base-controllers@2.8.0, npm/@toruslabs/http-helpers@3.3.0, npm/@toruslabs/openlogin-ed25519@3.2.0, npm/@toruslabs/openlogin-jrpc@3.2.0, npm/@toruslabs/openlogin-utils@3.0.0, npm/@toruslabs/openlogin@3.2.1, npm/@toruslabs/solana-embed@0.3.4, npm/@toruslabs/torus-embed@2.2.9, npm/@trezor/analytics@1.0.5, npm/@trezor/blockchain-link-types@1.0.4, npm/@trezor/blockchain-link-utils@1.0.5, npm/@trezor/blockchain-link@2.1.15, npm/@trezor/connect-analytics@1.0.4, npm/@trezor/connect-common@0.0.18, npm/@trezor/connect-web@9.1.1, npm/@tsconfig/node10@1.0.8, npm/@tsconfig/node12@1.0.9, npm/@tsconfig/node14@1.0.1, npm/@tsconfig/node16@1.0.2, npm/@tsconfig/svelte@2.0.1, npm/@types/body-parser@1.19.2, npm/@types/bonjour@3.5.10, npm/@types/connect-history-api-fallback@1.3.5, npm/@types/connect@3.4.35, npm/@types/eslint-scope@3.7.3, npm/@types/estree@1.0.5, npm/@types/express-serve-static-core@4.17.28, npm/@types/express@4.17.13, npm/@types/glob@7.2.0, npm/@types/http-proxy@1.17.8, npm/@types/istanbul-lib-coverage@2.0.4, npm/@types/js-cookie@2.2.7, npm/@types/json-schema@7.0.9, npm/@types/lodash.merge@4.6.6, npm/@types/lodash.partition@4.6.6, npm/@types/lodash.uniqby@4.7.6, npm/@types/lodash@4.14.178, npm/@types/node@18.15.13, npm/@types/prop-types@15.7.4, npm/@types/react@18.0.9, npm/@types/retry@0.12.1, npm/@types/secp256k1@4.0.3, npm/@types/serve-index@1.9.1, npm/@types/sockjs@0.3.33, npm/@types/use-sync-external-store@0.0.3, npm/@types/ws@7.4.7, npm/@typescript-eslint/eslint-plugin@4.33.0, npm/@typescript-eslint/parser@4.33.0, npm/@web3-onboard/coinbase@2.2.7, npm/@web3-onboard/walletconnect@2.5.4, npm/css-loader@6.11.0, npm/style-loader@3.3.4, npm/webpack-cli@5.1.4, npm/webpack-dev-server@4.15.2
Description
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package. To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)