Update Capsule Modal

[vr2amesh]

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

• [ ] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
• [ ] Check the box that allows repo maintainers to update this PR
• [ ] Test locally to make sure this feature/fix works
• [ ] Run yarn check-all to confirm there are not any associated errors
• [ ] Confirm this PR passes Circle CI checks
• [ ] Add or update relevant information in the documentation

Docs Checklist

• [ ] Include a screenshot of any changes (see docs README on running locally)
• [ ] Add/update the appropriate package README (if applicable)
• [ ] Add/update the related module in the docs demo (if applicable)
• [ ] Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package. To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

• [ ] send transaction
• [ ] switch chains
• [ ] sign message
• [ ] sign typed message
• [ ] disconnect

Tests with demo app (SDK)

• [ ] send transaction
• [ ] switch chains
• [ ] sign message
• [ ] sign typed message
• [ ] disconnect

[leightkt]

@vr2amesh I was able to connect a capsule wallet to the demo, but not complete any of the checklist functions listed: send transaction switch chains sign message sign typed message

can you take a look?

[vr2amesh]

@vr2amesh I was able to connect a capsule wallet to the demo, but not complete any of the checklist functions listed: send transaction switch chains sign message sign typed message

can you take a look?

Will take a look now

[vr2amesh]

@leightkt Hi there, I just tested it now, and I was able to do all of those checklist functions. What are you seeing on your end?

[leightkt]

@vr2amesh I connect my wallet and can switch chains- but when I click sign transaction or send transaction- nothing happnes

[vr2amesh]

@leightkt What do you see in the console? The stuff that comes up there is consistent with the output we get from other wallets as well. I don't think the signTransaction is supported in the demo app. I confirmed that the behavior of Capsule wallet is consistent with those other ones/

[leightkt]

@vr2amesh ok so I see a console log of the signed message- I was expecting some sort of UI with Capsule. I was also able to confirm sending a transaction- again, is there no UI for these functions? (just want to make sure I'm understanding correctly).

[vr2amesh]

@leightkt Ah! I understand now. There isn't a UI for these functions. We're meant to be an embedded wallet with minimal UI, so this is expected behavior

[leightkt]

@vr2amesh got ya- thank you for confirming and sorry for the confusion! overall- this PR is looking good. Can you please remove the capsule/yarn.lock file, the update to PORT in package.json and merge in the most recent web3onboard develop branch? I can then get this approved/merged.

[vr2amesh]

@leightkt Absolutely will do! Thank you so much

[socket-security[bot]]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request