blocknative / web3-onboard

Client library to onboard users to web3 apps
https://onboard.blocknative.com/
MIT License
817 stars 479 forks source link

feat: update the `@metamask/sdk` package to version `0.18.6` #2173

Closed omridan159 closed 2 months ago

omridan159 commented 2 months ago

Description

Update the @metamask/sdk package to version 0.18.6

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

Docs Checklist

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package. To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

Tests with demo app (SDK)

socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@unstoppabledomains/resolution@8.5.0 Transitive: network +3 1.11 MB dchan0319
npm/@web3-onboard/react@2.8.11 None 0 24.5 kB cmeisl
npm/d@1.0.1 None +1 125 kB medikoo
npm/es5-ext@0.10.62 eval +1 402 kB medikoo
npm/es6-symbol@3.1.3 None +2 131 kB medikoo
npm/eslint-config-next@12.2.5 unsafe Transitive: environment, filesystem +7 1.31 MB vercel-release-bot
npm/eslint@8.22.0 filesystem +8 3.14 MB eslintbot
npm/is-core-module@2.10.0 None 0 27.3 kB ljharb
npm/jsx-ast-utils@3.3.3 None 0 230 kB ljharb
npm/next-tick@1.1.0 None 0 7.65 kB medikoo
npm/next@12.2.5 environment, filesystem, network, shell, unsafe +16 577 MB vercel-release-bot
npm/object.assign@4.1.3 None 0 1.14 MB ljharb

🚮 Removed packages: npm/0xsequence@0.43.1, npm/@adraffy/ens-normalize@1.10.1, npm/@apocentre/alias-sampling@0.5.3, npm/@arcana/auth@1.0.7, npm/@babel/code-frame@7.12.11, npm/@babel/compat-data@7.17.0, npm/@babel/helper-define-polyfill-provider@0.3.1, npm/@babel/helper-plugin-utils@7.16.7, npm/@babel/plugin-transform-runtime@7.17.0, npm/@babel/runtime@7.16.7, npm/@bitget-wallet/web3-sdk@0.0.8, npm/@blocto/dappauth@2.1.0, npm/@blocto/sdk@0.9.1, npm/@cedelabs/providers@1.5.0, npm/@celo/base@3.2.0, npm/@celo/utils@3.2.0, npm/@chainsafe/as-sha256@0.3.1, npm/@chainsafe/persistent-merkle-tree@0.4.2, npm/@chainsafe/ssz@0.9.4, npm/@coinbase/wallet-sdk@3.9.1, npm/@cspotcode/source-map-consumer@0.8.0, npm/@cspotcode/source-map-support@0.7.0, npm/@discoveryjs/json-ext@0.5.6, npm/@emotion/babel-plugin@11.11.0, npm/@emotion/cache@11.11.0, npm/@emotion/is-prop-valid@1.2.1, npm/@emotion/react@11.11.4, npm/@emotion/serialize@1.1.2, npm/@emotion/styled@11.11.5, npm/@emotion/unitless@0.8.1, npm/@esbuild/android-arm64@0.18.20, npm/@esbuild/android-arm@0.18.20, npm/@esbuild/android-x64@0.18.20, npm/@esbuild/darwin-arm64@0.18.20, npm/@esbuild/darwin-x64@0.18.20, npm/@esbuild/freebsd-arm64@0.18.20, npm/@esbuild/freebsd-x64@0.18.20, npm/@esbuild/linux-arm64@0.18.20, npm/@esbuild/linux-arm@0.18.20, npm/@esbuild/linux-ia32@0.18.20, npm/@esbuild/linux-loong64@0.18.20, npm/@esbuild/linux-mips64el@0.18.20, npm/@esbuild/linux-ppc64@0.18.20, npm/@esbuild/linux-riscv64@0.18.20, npm/@esbuild/linux-s390x@0.18.20, npm/@esbuild/linux-x64@0.18.20, npm/@esbuild/netbsd-x64@0.18.20, npm/@esbuild/openbsd-x64@0.18.20, npm/@esbuild/sunos-x64@0.18.20, npm/@esbuild/win32-arm64@0.18.20, npm/@esbuild/win32-ia32@0.18.20, npm/@esbuild/win32-x64@0.18.20, npm/@eslint/eslintrc@0.4.3, npm/@ethereumjs/common@2.5.0, npm/@ethereumjs/rlp@4.0.1, npm/@ethereumjs/tx@3.3.2, npm/@ethereumjs/util@8.0.6, npm/@ethersproject/abi@5.7.0, npm/@ethersproject/abstract-provider@5.7.0, npm/@ethersproject/abstract-signer@5.7.0, npm/@ethersproject/address@5.7.0, npm/@ethersproject/base64@5.7.0, npm/@ethersproject/bignumber@5.7.0, npm/@ethersproject/bytes@5.7.0, npm/@ethersproject/constants@5.7.0, npm/@ethersproject/hash@5.7.0, npm/@ethersproject/keccak256@5.7.0, npm/@ethersproject/logger@5.7.0, npm/@ethersproject/networks@5.7.1, npm/@ethersproject/properties@5.7.0, npm/@ethersproject/rlp@5.7.0, npm/@ethersproject/signing-key@5.7.0, npm/@ethersproject/strings@5.7.0, npm/@ethersproject/transactions@5.7.0, npm/@ethersproject/web@5.7.1, npm/@findeth/abi@0.3.1, npm/@formatjs/ecma402-abstract@1.11.3, npm/@formatjs/icu-messageformat-parser@2.0.18, npm/@gsap/react@2.1.0, npm/@hapi/address@5.1.1, npm/@hapi/formula@3.0.2, npm/@hapi/hoek@11.0.2, npm/@hapi/pinpoint@2.0.1, npm/@hapi/tlds@1.0.1, npm/@humanwhocodes/config-array@0.5.0, npm/@infinitywallet/infinity-connector@1.0.6, npm/@ioredis/commands@1.2.0, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/trace-mapping@0.3.19, npm/@keepkey/device-protocol@7.7.0, npm/@keystonehq/base-eth-keyring@0.6.4, npm/@keystonehq/eth-keyring@0.14.4, npm/@lit-labs/ssr-dom-shim@1.1.0, npm/@lit/reactive-element@1.6.1, npm/@magic-sdk/commons@4.1.0, npm/@magic-sdk/provider@28.0.2, npm/@magic-sdk/types@24.0.1, npm/@metamask/detect-provider@2.0.0, npm/@metamask/eth-json-rpc-middleware@11.0.0, npm/@metamask/eth-sig-util@5.1.0, npm/@metamask/json-rpc-engine@7.3.3, npm/@metamask/json-rpc-middleware-stream@6.0.2, npm/@metamask/object-multiplex@1.2.0, npm/@metamask/onboarding@1.0.1, npm/@metamask/post-message-stream@6.2.0, npm/@metamask/providers@8.1.1, npm/@metamask/rpc-errors@6.2.1, npm/@metamask/safe-event-emitter@2.0.0, npm/@metamask/sdk-communication-layer@0.14.3, npm/@metamask/sdk-install-modal-web@0.14.1, npm/@metamask/sdk@0.14.3, npm/@web3-onboard/coinbase@2.2.7, npm/@web3-onboard/injected-wallets@2.10.16, npm/@web3-onboard/walletconnect@2.5.5, npm/css-loader@6.11.0, npm/style-loader@3.3.4, npm/webpack-cli@5.1.4, npm/webpack-dev-server@4.15.2

View full report↗︎

socket-security[bot] commented 2 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Protestware/Troll package npm/es5-ext@0.10.62
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
Install scripts npm/es5-ext@0.10.62
  • Install script: postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/es5-ext@0.10.62
leightkt commented 2 months ago

@omridan159 this looks good- can you update the version in packages/metamask/package.json to 2.0.6-alpha.1