add echooowallet - Githubissues

rqzrqh commented 2 months ago

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

[x] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
[x] Check the box that allows repo maintainers to update this PR
[x] Test locally to make sure this feature/fix works
[x] Run yarn check-all to confirm there are not any associated errors
[x] Confirm this PR passes Circle CI checks
[x] Add or update relevant information in the documentation

Docs Checklist

[x] Include a screenshot of any changes (see docs README on running locally)
[x] Add/update the appropriate package README (if applicable)
[x] Add/update the related module in the docs demo (if applicable)
[x] Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package. To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

[x] send transaction
[x] switch chains
[x] sign message
[x] sign typed message
[x] disconnect

Tests with demo app (SDK)

[x] send transaction
[x] switch chains
[x] sign message
[x] sign typed message
[x] disconnect

socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@adraffy/ens-normalize@1.10.0	None	`0`	441 kB	adraffy
npm/@babel/code-frame@7.24.2	environment	`+1`	44.5 kB	nicolo-ribaudo
npm/@babel/compat-data@7.24.4	None	`0`	65.2 kB	nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6	None	`+2`	82.5 kB	nicolo-ribaudo
npm/@babel/helper-module-imports@7.22.15	None	`0`	54.4 kB	nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.1	None	`0`	31.7 kB	nicolo-ribaudo
npm/@babel/helper-validator-identifier@7.24.5	None	`0`	49.2 kB	nicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5	None	`0`	11.7 kB	nicolo-ribaudo
npm/@babel/runtime@7.23.2	None	`0`	247 kB	nicolo-ribaudo
npm/@babel/types@7.24.5	environment	`0`	2.41 MB	nicolo-ribaudo
npm/@blocto/dappauth@2.1.0	None	`0`	20.1 kB	scottphc
npm/@celo/utils@3.2.0	None	`+2`	767 kB	alecps
npm/@chakra-ui/accordion@1.4.12	environment	`+11`	1.22 MB	segunadebayo
npm/@chakra-ui/alert@1.3.7	environment	`+7`	762 kB	segunadebayo
npm/@chakra-ui/anatomy@1.3.0	environment	`+7`	760 kB	segunadebayo
npm/@chakra-ui/avatar@1.3.11	environment	`+10`	1.06 MB	segunadebayo
npm/@chakra-ui/breadcrumb@1.3.6	environment	`+7`	765 kB	segunadebayo
npm/@chakra-ui/button@1.5.10	environment	`+11`	1.06 MB	segunadebayo
npm/@chakra-ui/checkbox@1.7.1	environment	`+11`	1.17 MB	segunadebayo
npm/@chakra-ui/clickable@1.2.6	environment	`0`	73.9 kB	segunadebayo
npm/@chakra-ui/close-button@1.2.7	environment	`+7`	748 kB	segunadebayo
npm/@chakra-ui/color-mode@2.2.0	None	`+1`	119 kB	segunadebayo
npm/@chakra-ui/control-box@1.1.6	environment	`+7`	750 kB	segunadebayo
npm/@chakra-ui/counter@1.2.10	environment	`+2`	273 kB	segunadebayo
npm/@chakra-ui/css-reset@1.1.3	environment	`0`	24.1 kB	segunadebayo
npm/@chakra-ui/editable@1.4.2	environment	`+9`	1.05 MB	segunadebayo
npm/@chakra-ui/focus-lock@1.2.6	environment	`0`	13.1 kB	segunadebayo
npm/@chakra-ui/icon@2.0.5	environment	`+7`	754 kB	segunadebayo
npm/@chakra-ui/icons@2.1.1	Transitive: environment	`+8`	1.16 MB	segunadebayo
npm/@chakra-ui/input@1.4.6	environment	`+10`	1.1 MB	segunadebayo
npm/@chakra-ui/layout@1.8.0	environment	`+7`	909 kB	segunadebayo
npm/@chakra-ui/live-region@1.1.6	environment	`0`	17.4 kB	segunadebayo
npm/@chakra-ui/media-query@2.0.4	environment	`+11`	8.89 MB	segunadebayo
npm/@chakra-ui/menu@1.8.12	environment	`+13`	3.03 MB	segunadebayo
npm/@chakra-ui/modal@1.11.1	environment	`+11`	1.24 MB	segunadebayo
npm/@chakra-ui/number-input@1.4.7	environment	`+10`	1.18 MB	segunadebayo
npm/@chakra-ui/pin-input@1.7.11	environment	`+10`	1.09 MB	segunadebayo
npm/@chakra-ui/popover@1.11.9	environment	`+11`	2.62 MB	segunadebayo
npm/@chakra-ui/progress@1.2.6	environment	`+7`	794 kB	segunadebayo
npm/@chakra-ui/provider@1.7.14	environment	`+9`	2.1 MB	segunadebayo
npm/@chakra-ui/radio@1.5.1	environment	`+11`	1.15 MB	segunadebayo
npm/@chakra-ui/react-utils@1.2.3	environment	`0`	19 kB	segunadebayo
npm/@chakra-ui/react@1.8.9	environment Transitive: eval	`+40`	15.6 MB	segunadebayo
npm/@chakra-ui/theme-tools@1.3.6	environment	`+8`	1.06 MB	segunadebayo
npm/@chakra-ui/utils@1.10.4	environment	`+3`	370 kB	segunadebayo
npm/@coinbase/wallet-sdk@3.9.3	network	`0`	368 kB	cb-felix-z
npm/@cosmjs/amino@0.29.5	None	`+1`	227 kB	webmaster128
npm/@cosmjs/crypto@0.29.4	None	`0`	139 kB	webmaster128
npm/@cosmjs/encoding@0.29.5	None	`0`	24.6 kB	webmaster128
npm/@cosmjs/math@0.29.5	None	`0`	36.8 kB	webmaster128
npm/@cosmjs/proto-signing@0.29.5	None	`0`	80 kB	webmaster128
npm/@cosmjs/stream@0.29.5	None	`0`	30.4 kB	webmaster128
npm/@cosmjs/tendermint-rpc@0.29.5	network Transitive: environment	`+3`	744 kB	webmaster128
npm/@cosmjs/utils@0.29.5	None	`0`	14.5 kB	webmaster128
npm/@emotion/is-prop-valid@1.2.2	environment	`+1`	33.5 kB	emotion-release-bot
npm/@emotion/react@11.11.4	environment Transitive: filesystem	`+11`	1.9 MB	emotion-release-bot
npm/@emotion/serialize@1.1.4	environment	`+3`	91.4 kB	emotion-release-bot
npm/@emotion/styled@11.11.5	environment Transitive: filesystem	`+8`	1.32 MB	emotion-release-bot
npm/@emotion/unitless@0.8.1	environment	`0`	7.05 kB	emotion-release-bot
npm/@ethereumjs/common@2.6.5	None	`+1`	2.84 MB	holgerd77
npm/@ethereumjs/tx@3.5.2	None	`0`	431 kB	holgerd77
npm/@ethereumjs/util@8.1.0	None	`+5`	2.47 MB	holgerd77
npm/@jridgewell/gen-mapping@0.3.5	None	`0`	81.6 kB	jridgewell
npm/@jridgewell/set-array@1.2.1	None	`0`	17.9 kB	jridgewell
npm/@jridgewell/trace-mapping@0.3.25	None	`+1`	224 kB	jridgewell
npm/@lit-labs/ssr-dom-shim@1.1.2	environment	`0`	33.7 kB	lit-robot
npm/@lit/reactive-element@1.6.3	None	`0`	788 kB	lit-robot
npm/@metamask/json-rpc-engine@7.3.3	None	`0`	96.9 kB	metamaskbot
npm/@metamask/rpc-errors@6.2.1	None	`0`	129 kB	metamaskbot
npm/@metamask/safe-event-emitter@2.0.0	None	`0`	7.65 kB	whymarrh
npm/@metamask/sdk-communication-layer@0.20.2	environment	`0`	3.04 MB	metamaskbot
npm/@metamask/sdk-install-modal-web@0.20.2	None	`0`	548 kB	metamaskbot
npm/@metamask/sdk@0.20.3	Transitive: network	`+6`	32.9 MB	metamaskbot
npm/@metamask/utils@8.4.0	None	`+3`	1.12 MB	metamaskbot
npm/@motionone/animation@10.16.3	None	`+2`	111 kB	popmotion
npm/@motionone/dom@10.16.4	None	`+1`	524 kB	popmotion
npm/@motionone/types@10.16.3	None	`0`	11 kB	popmotion
npm/@motionone/utils@10.16.3	None	`0`	33 kB	popmotion
npm/@ngraveio/bc-ur@1.1.6	None	`+1`	138 kB	antwnic4
npm/@noble/curves@1.2.0	None	`0`	1.35 MB	paulmillr
npm/@noble/hashes@1.3.2	None	`0`	747 kB	paulmillr
npm/@noble/secp256k1@1.7.1	None	`0`	111 kB	paulmillr
npm/@protobufjs/aspromise@1.1.2	None	`0`	9.05 kB	dcode
npm/@safe-global/safe-apps-provider@0.18.0	None	`0`	33 kB	dasanra
npm/@safe-global/safe-apps-sdk@8.1.0	Transitive: network	`+1`	249 kB	dasanra
npm/@scure/base@1.1.3	None	`0`	77.8 kB	paulmillr
npm/@scure/bip32@1.3.2	None	`0`	57.7 kB	paulmillr
npm/@scure/bip39@1.2.1	None	`0`	357 kB	paulmillr
npm/@shapeshiftoss/hdwallet-core@1.52.2	None	`+3`	11.6 MB	shapeshift-ci-bot
npm/@sindresorhus/is@4.6.0	None	`0`	57.5 kB	sindresorhus
npm/@solana/web3.js@1.87.1	environment, eval, network	`+1`	11.4 MB	buffalojoec

🚮 Removed packages: npm/@babel/parser@7.23.0, npm/@unstoppabledomains/resolution@8.5.0, npm/@web3-onboard/react@2.8.11, npm/bignumber.js@9.1.2, npm/d@1.0.1, npm/es5-ext@0.10.62, npm/es6-symbol@3.1.3, npm/eslint-config-next@12.2.5, npm/eslint@8.22.0, npm/is-core-module@2.10.0, npm/jsx-ast-utils@3.3.3, npm/next-tick@1.1.0, npm/next@12.2.5, npm/normalize-path@3.0.0, npm/object.assign@4.1.3

View full report↗︎

socket-security[bot] commented 2 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
Install scripts	npm/keccak@1.4.0	Install script: install Source: `npm run rebuild \|\| echo "Keccak bindings compilation fail. Pure JS implementation will be used."`	orphan: npm/keccak@1.4.0

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/keccak@1.4.0

lianshao123 commented 2 months ago

Is there any documentation that can help me complete the import of wallet plugin to blocknative? @Adamj1232

Adamj1232 commented 2 months ago

@lianshao123 Steps to get this PR ready to go would be:

Remove packages/echooo completely and all contained files
revert echooo package changes to .circleci/config.yml
remove the [...36]echooo/+page.md
remove web3-onboard/echo from docs/package.json & services/onboard.js

Here is some documentation around adding a wallet and contributing to the project - https://onboard.blocknative.com/docs/overview/contribution-guide#how-can-i-add-a-new-wallet-%F0%9F%92%B3