Closed k-xo closed 4 months ago
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/core@7.23.2, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/parser@7.23.0, npm/@babel/plugin-syntax-jsx@7.22.5, npm/@babel/types@7.23.0, npm/@jridgewell/gen-mapping@0.3.3, npm/@unstoppabledomains/resolution@8.5.0, npm/@web3-onboard/react@2.8.11, npm/d@1.0.1, npm/es5-ext@0.10.62, npm/es6-symbol@3.1.3, npm/eslint-config-next@12.2.5, npm/eslint@8.22.0, npm/is-core-module@2.10.0, npm/jsx-ast-utils@3.3.3, npm/next-tick@1.1.0, npm/next@12.2.5, npm/object.assign@4.1.3
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
@k-xo looking good, just a few more comments/questions. Are there any build env configurations that would need to be considered or added to our build env docs? ex. https://github.com/blocknative/web3-onboard/blob/76a38237a2d5e71cce73ecbf979cf249a532488d/docs/src/routes/docs/%5B...3%5Dmodules/%5B...1%5Dcore/%2Bpage.md?plain=1#L1460
@k-xo looking good, just a few more comments/questions. Are there any build env configurations that would need to be considered or added to our build env docs? ex.
Requests comments / changes made :). For the build configuration I don't think we need to add any build env docs, we use the web crypto api for our needs so far, which I believe should work for most / all browsers.
Description
Passport is an MPC-based programmable, distributed, and non-custodial key management system, that allows users to generate wallets, scoped to their application, either via user Passkeys, our signer allows you to sign messages and transactions with a Passport Network account.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package. To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)