blocknative / web3-onboard

Client library to onboard users to web3 apps
https://onboard.blocknative.com/
MIT License
837 stars 496 forks source link

fix: add passport wallet #2195

Closed k-xo closed 4 months ago

k-xo commented 4 months ago

Description

Passport is an MPC-based programmable, distributed, and non-custodial key management system, that allows users to generate wallets, scoped to their application, either via user Passkeys, our signer allows you to sign messages and transactions with a Passport Network account.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

Docs Checklist

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package. To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

Tests with demo app (SDK)

socket-security[bot] commented 4 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@adraffy/ens-normalize@1.10.0 None 0 441 kB adraffy
npm/@emotion/unitless@0.8.1 environment 0 7.05 kB emotion-release-bot
npm/@metamask/safe-event-emitter@2.0.0 None 0 7.65 kB whymarrh
npm/@noble/hashes@1.3.2 None 0 747 kB paulmillr
npm/@protobufjs/aspromise@1.1.2 None 0 9.05 kB dcode
npm/@types/node@10.17.60 None 0 632 kB types
npm/base64url@3.0.1 None 0 7.55 kB brianloveswords
npm/big-integer@1.6.51 None 0 164 kB peterolson
npm/bignumber.js@9.1.2 None 0 351 kB mikemcl
npm/bitcoin-ops@1.4.1 None 0 4.38 kB dcousens
npm/blakejs@1.2.1 None 0 156 kB dcposch
npm/buffer-from@1.1.2 None 0 5.05 kB linusu
npm/clsx@1.2.1 None 0 5.67 kB lukeed
npm/commander@2.20.3 filesystem, shell 0 62.4 kB abetomo
npm/csstype@3.1.3 None 0 1.25 MB faddee
npm/es6-promise@4.2.8 None 0 315 kB stefanpenner
npm/eventemitter3@5.0.1 None 0 73.4 kB lpinca
npm/fast-safe-stringify@2.1.1 None 0 39.7 kB matteo.collina
npm/http@0.0.1-security None 0 464 B andreeleuterio
npm/https-browserify@1.0.0 network 0 2.79 kB feross
npm/is-docker@2.2.1 filesystem 0 3.01 kB sindresorhus
npm/is-stream@2.0.1 None 0 5.93 kB sindresorhus
npm/json-rpc-random-id@1.0.1 None 0 2.12 kB kumavis
npm/json-stringify-safe@5.0.1 None 0 12.7 kB isaacs
npm/lodash@4.17.21 None 0 1.41 MB bnjmnt4n
npm/mime-db@1.52.0 None 0 206 kB dougwilson
npm/minimist@1.2.8 None 0 54.5 kB ljharb
npm/node-forge@1.3.1 None 0 1.66 MB davidlehn
npm/node-gyp-build@4.6.1 environment, filesystem 0 13.2 kB mafintosh
npm/normalize-path@3.0.0 None 0 9.22 kB jonschlinkert
npm/object-inspect@1.13.1 None 0 97.2 kB ljharb
npm/os-browserify@0.3.0 None 0 2.74 kB coderpuppy
npm/path-browserify@1.0.1 None 0 54.3 kB goto-bus-stop
npm/process@0.11.10 None 0 15.3 kB cwmma
npm/qrcode-generator@1.4.4 None 0 117 kB kazuhikoarase
npm/safer-buffer@2.1.2 None 0 42.3 kB chalker
npm/svelte@3.59.2 None 0 10.6 MB conduitry
npm/typeforce@1.18.0 None 0 19.1 kB dcousens
npm/uuid@8.3.2 None 0 116 kB ctavan
npm/varint@5.0.0 None 0 9.03 kB chrisdickinson
npm/webextension-polyfill@0.10.0 None 0 198 kB addons-robot
npm/xtend@4.0.2 None 0 6.46 kB raynos

🚮 Removed packages: npm/@babel/core@7.23.2, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/parser@7.23.0, npm/@babel/plugin-syntax-jsx@7.22.5, npm/@babel/types@7.23.0, npm/@jridgewell/gen-mapping@0.3.3, npm/@unstoppabledomains/resolution@8.5.0, npm/@web3-onboard/react@2.8.11, npm/d@1.0.1, npm/es5-ext@0.10.62, npm/es6-symbol@3.1.3, npm/eslint-config-next@12.2.5, npm/eslint@8.22.0, npm/is-core-module@2.10.0, npm/jsx-ast-utils@3.3.3, npm/next-tick@1.1.0, npm/next@12.2.5, npm/object.assign@4.1.3

View full report↗︎

socket-security[bot] commented 4 months ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Adamj1232 commented 4 months ago

@k-xo looking good, just a few more comments/questions. Are there any build env configurations that would need to be considered or added to our build env docs? ex. https://github.com/blocknative/web3-onboard/blob/76a38237a2d5e71cce73ecbf979cf249a532488d/docs/src/routes/docs/%5B...3%5Dmodules/%5B...1%5Dcore/%2Bpage.md?plain=1#L1460

k-xo commented 4 months ago

@k-xo looking good, just a few more comments/questions. Are there any build env configurations that would need to be considered or added to our build env docs? ex.

https://github.com/blocknative/web3-onboard/blob/76a38237a2d5e71cce73ecbf979cf249a532488d/docs/src/routes/docs/%5B...3%5Dmodules/%5B...1%5Dcore/%2Bpage.md?plain=1#L1460

Requests comments / changes made :). For the build configuration I don't think we need to add any build env docs, we use the web crypto api for our needs so far, which I believe should work for most / all browsers.