Closed MarkNerdi closed 1 week ago
Hi @MarkNerdi it looks like the build is failing within the PR status checks - can you have a look when you get a moment?
@Adamj1232 Updated the code, can you run the workflow again pls? :pray:
No dependency changes detected. Learn more about Socket for GitHub ↗︎
👍 No dependency changes detected in pull request
@MarkNerdi local testing and build went well. I formatted the files and added the bloom module to the internal demo - packages/demo/package.json
where it wasnt added. Was bloom wallet functionality tested using the internal demo on your end?
@Adamj1232
Yes i tested it locally, for that i had to remove @web3onboad/bloom
from the package.json, as that isnt published yet
@MarkNerdi code is looking good! When testing locally I am getting the following error:
@Adamj1232 This error occurs when you dont have bloom installed on you machine. Do you have an example in your project where a wallet prompts the user to download it? i could add that
@Adamj1232 This error occurs when you dont have bloom installed on you machine. Do you have an example in your project where a wallet prompts the user to download it? i could add that
@MarkNerdi ah gotcha, yeah we would def want to display a download message so users can add Bloom if they want - here is an example to display that message formatted using a helper function - https://github.com/blocknative/web3-onboard/blob/eb205fb5356b6851afb764e42f06ac97b45052d2/packages/okx/src/index.ts#L35
@Adamj1232
Sadly there is no consistent way to determine if an application is installed via the browser. The code in the newest PR checks if updating location.href
to a specified protocl throws an error or not, which happens on Windows (and Mac) i think.
Description
This PR add Bloom wallet to the list of supported wallets
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package. To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)