blocknative / web3-onboard

Client library to onboard users to web3 apps
https://onboard.blocknative.com/
MIT License
837 stars 496 forks source link

fix: integrate web3auth in demo app #2233

Closed bengobeil closed 3 months ago

bengobeil commented 3 months ago

Description

As per previously discussed, integrate new web3auth package in demo app. I added React as a dependency, since demo it is executed as opposed to being a package, wouldn't work otherwise.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

Docs Checklist

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package. To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

Tests with demo app (SDK)

bengobeil commented 3 months ago

image image

bengobeil commented 3 months ago

@Adamj1232 ready for review

bengobeil commented 3 months ago

Hey @Adamj1232, it seems as though calling setChain on the useSetChain hook when connected to web3auth wallet does not update the provider in the useConnectWallet hook. I'm not familiar with the codebase enough to fix this, I've been taking a look at day and it seems as though web3auth is not integrate with the rx/js based state, not sure about this. Would it be possible to take a look and point me in the right direction?