search

blocknetdx / blocknet

Official Blocknet cryptocurrency wallet
https://www.blocknet.org
MIT License
214 stars 94 forks source link

add check (min_size > maker_size) condition #536

Closed Carver182 closed 3 years ago

Carver182 commented 3 years ago

Scenario:

When a user posts a partial order via CLI or wallet console, XBridge is currently allowing orders where minimum_size to be > maker_size.

This shouldn't be possible as minimum_size should be a percentage (0-100%) of the maker_size.

Request parameters: dxMakePartialOrder [maker] [maker_size] [maker_address] [taker] [taker_size] [taker_address] [minimum_size] repost dryrun

Steps to reproduce:

Place a 'partial order' via the wallet console or CLI where maker_size > min_size:

Example command: dxMakePartialOrder BLOCK 1 Bch1hVnEvUiLZvQkir3HDT85LHz6CxZUR LTC 0.025135 LbnY5xWQGF5Er2MeiufauNDWtVZaV4udiE 1.1 true

Current behaviour:

Order accepted by Snode

Expected:

Order should be canceled by Snode

atcsecure commented 3 years ago

we do not merge against master branch