search

blocknetdx / exrproxy-env

erp-ethserver
7 stars 10 forks source link

updated link to download env_installer.sh #201

Closed ConanMishler closed 2 years ago

ConanMishler commented 2 years ago

We should mention it's necessary to run the script twice, following the instructions to run it a second time after it logs you out. Wouldn't be a bad idea to explain that the reason it is required to be run (again) after 1 October is to accommodate a Python dependency broken by a 3rd party.

Also that the script only configures the Python environment for the exrproxy-env located in the user's home directory. If they have it located elsewhere they will need to switch to using it in the home directory or engage in some manual tweaking.

Good points! Will do!

ConanMishler commented 2 years ago

We should mention it's necessary to run the script twice, following the instructions to run it a second time after it logs you out. Wouldn't be a bad idea to explain that the reason it is required to be run (again) after 1 October is to accommodate a Python dependency broken by a 3rd party.

Also that the script only configures the Python environment for the exrproxy-env located in the user's home directory. If they have it located elsewhere they will need to switch to using it in the home directory or engage in some manual tweaking.

@walkjivefly I've updated the README as per your suggestions. Please have a look and either approve the PR or let me know what else should change. Thx!

ConanMishler commented 2 years ago

You could change "detect" to "detects" in line 21 but LGTM

@walkjivefly Ha! I thought I could make this small change and then merge without bothering you again, but now it wants your approval again! 😜