search

blocknotes / activeadmin_blaze_theme

A theme for Active Admin based on Blaze CSS 3.x
MIT License
46 stars 12 forks source link

ActiveAdmin 3 support #29

Closed Fs00 closed 11 months ago

Fs00 commented 12 months ago

The gem currently has a requirement on ActiveAdmin 2.x, which causes the inability to upgrade to AA 3. I don't know if the requirement can simply be lifted or there are some changes to do, but it would be nice to have AA 3 support too.

kusihed75 commented 11 months ago

Hi everybody

when I change the line 27 in the gemspec file to

spec.add_runtime_dependency 'activeadmin', '>= 2.0', '< 4'

and load it locally in the gemfile (gem 'activeadmin_blaze_theme', path: './lib/activeadmin_blaze_theme')

then things seem to work just fine.

So that change should allow activeadmin_blaze_theme to work with AA3...

What do you think about that change request?

kusihed75 commented 11 months ago

By the way, the fork https://github.com/glebtv/activeadmin_blaze_theme already did this update for AA3.. Are you willing to do that as well in this repository at all?

blocknotes commented 11 months ago

Thanks for the issue @Fs00 - I have just updated the ActiveAdmin version range to support 3.x

Fs00 commented 11 months ago

Thank you!