search

blockonomics / opencart-plugin

Bitcoin plugin for Opencart v4 by Blockonomics
4 stars 7 forks source link

Set order status as Pending as soon as order is created. Issue #5 #10

Closed jusasiiv closed 4 years ago

jusasiiv commented 4 years ago

Issue #5

DarrenWestwood commented 4 years ago

The issue can be replicated by changing the Opencart SSL setting Opencart Settings SSL

&1 is being added added to the url by $this->url->link, I have had success simply replacing &1 in $default_callback_url.

More information here

jusasiiv commented 4 years ago

Very good debugging

Added a fix for the malformed Callback URL in case SSL is activated

jusasiiv commented 4 years ago

We are also marking the order as pending when it is created, however I do not see any benefits of this, and could possibly be reverted.

The reason was mentioned on the issue discussion. The idea behind this PR is to fix the orders not showing up anywhere in the UI:

All created orders go to status "Missing order" which is default if nothing is set. PR adds the order status to "Pending" as soon as the order is created. Missing orders do not show up in UI anywhere unless they are specifically searched for.

blockonomics commented 4 years ago

Please resolve conflicts