search

blockonomics / opencart-plugin

Bitcoin plugin for Opencart v4 by Blockonomics
4 stars 7 forks source link

Reuse address on same order, issue #8 #9

Closed jusasiiv closed 4 years ago

jusasiiv commented 4 years ago

If customer backs out from payment page and clicks on Confirm Order again, reuse the existing BTC address.

Notes: Updates price and timestamp of order to DB to prevent price manipulation. Pressing F5 on payment page restarts time period and updates price.

DarrenWestwood commented 4 years ago

Using the browser back button and then clicking Confirm Order is creating a new order id on my end, could you confirm if this is the same behaviour on your end?

Notes: Updates price and timestamp of order to DB to prevent price manipulation. Pressing F5 on payment page restarts time period and updates price.

Alternatively, in the future we can also check the timestamp to test if the order is expired, before updating the price and timestamp in the DB. We can also look into changing the behaviour of Pressing F5 for already expired orders to refresh the price and timer.

jusasiiv commented 4 years ago

Using the browser back button and then clicking Confirm Order is creating a new order id on my end, could you confirm if this is the same behaviour on your end?

Here is a recording of how it works for me. Notice order number and payment address not changing https://imgur.com/a/kb9X2Yu

This was tested with Firefox. Also order details cant be changed, else new order id is created