blockonomics / prestashop-plugin

Accept bitcoins on your website, payments go directly into your wallet
Other
16 stars 22 forks source link

v8 module is not installing on PS v8.0.4 #160

Closed anktd closed 1 year ago

anktd commented 1 year ago

Ticket here

Installation is not working (video attached)

https://github.com/blockonomics/prestashop-plugin/assets/97018228/a62ca64e-04f0-4a19-a0bf-cbee40714507


Error thrown -

Installation of module blockonomics failed. The version of your module is not compliant with your PrestaShop version.


Php error log:

[08-Jun-2023 10:13:45 Europe/Berlin] PHP Deprecated:  Using php-function "implode" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier. in C:\xampp\htdocs\prestashop_v804\vendor\smarty\smarty\libs\sysplugins\smarty_internal_compile_private_modifier.php on line 114
[08-Jun-2023 10:13:46 Europe/Berlin] PHP Deprecated:  Using php-function "stripslashes" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier. in C:\xampp\htdocs\prestashop_v804\vendor\smarty\smarty\libs\sysplugins\smarty_internal_compile_private_modifier.php on line 114
[08-Jun-2023 10:13:48 Europe/Berlin] PHP Deprecated:  Using php-function "substr" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier. in C:\xampp\htdocs\prestashop_v804\vendor\smarty\smarty\libs\sysplugins\smarty_internal_compile_private_modifier.php on line 114
[08-Jun-2023 10:13:50 Europe/Berlin] PHP Deprecated:  Using php-function "md5" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier. in C:\xampp\htdocs\prestashop_v804\vendor\smarty\smarty\libs\sysplugins\smarty_internal_compile_private_modifier.php on line 114

Seems another compatibility issue due to deprecated functions, similar to #157

anktd commented 1 year ago

Looks like the issue is due to the compatibility array values here Changing the ps_versions_compliancy array from $this->ps_versions_compliancy = [ 'min' => '8.0', 'max' => '8.0.1',]; to $this->ps_versions_compliancy = [ 'min' => '8.0', 'max' => '8.99.99',]; solves the issue.

DarrenWestwood commented 1 year ago

Fixed in https://github.com/blockonomics/prestashop-plugin/pull/161