search

blockonomics / whmcs-bitcoin-plugin

Accept bitcoins on your WHMCS, payments go directly into your wallet
8 stars 12 forks source link

Added button to select another currency. #107

Closed agarzon closed 3 years ago

agarzon commented 3 years ago

Added button to select another currency. #94 Also fix the redirection the checkout page when order expires. #106

blockonomics commented 3 years ago

We don't need a new button to change currency. We need to fix the fundamental problem of the URL being incorrect. It is required to split the checkout screen into two URLS : currency selection and payment (as in wordpress)

The automatically fixes many problem of payment expiry, going back and other problem of page refresh not working

agarzon commented 3 years ago

We don't need a new button to change currency. We need to fix the fundamental problem of the URL being incorrect. It is required to split the checkout screen into two URLS : currency selection and payment (as in wordpress)

Then the issue is different than the one I opened. Mine was only related with the lack of ability of change the currency once selected and this PR add that missing feature.

In the case of WP is different, there are 2 different pages with two different urls (used to be done years ago before the invention of single page applications).... of course we can do that.

And about the timing, it is just buggy code in javascript which works well in WP and not in WHMCS, (which is actually another different issue). It won't be fixed just because you refresh the page as in WP or having 2 different URL.