search

blockonomics / whmcs-bitcoin-plugin

Accept bitcoins on your WHMCS, payments go directly into your wallet
8 stars 12 forks source link

BCH integration #70

Closed DarrenWestwood closed 4 years ago

DarrenWestwood commented 4 years ago
shivaenigma commented 4 years ago

https://prnt.sc/r8u831

blockonomics commented 4 years ago

Address reuse is not working in BTC. Will test further after this is fixed

blockonomics commented 4 years ago

Let us use simple encryption to generate uuid from encrypt(order_id, key) instead of saving to DB https://stackoverflow.com/a/2490376/5043010

blockonomics commented 4 years ago

Change this for BCH payment https://prnt.sc/ravm7x (Edited: Not necessary to do this for now)

blockonomics commented 4 years ago

Let us use the below design for switcher screen. Also lets remove heading Bitcoin/Bitcoin Cash Payment and icon from the actual payment screen

https://www.figma.com/proto/GSOPajdDI8mWMORdCZ7NXopp/Blockonomics?node-id=966%3A638&viewport=234%2C284%2C0.568193256855011&scaling=min-zoom

DarrenWestwood commented 4 years ago

Updated with the new ui changes and encryption of order id instead of using uuid

shivaenigma commented 4 years ago

Screenshot from 2020-03-23 21-29-30

For BCH ... Put this: Note to webmaster: Please follow instructions here (freshdesk article link) to configure BCH payments

DarrenWestwood commented 4 years ago

Note to webmaster: Please follow instructions here (freshdesk article link) to configure BCH payments

Added with a739795

This is still linking to blockonomics.co even in case of BCH txid. Its just easier actually to remove the txid from this line, since the txid can anyway be seen on the invoice

Removed with 05725b1

shivaenigma commented 4 years ago

The whole process of converting the POST payment to GET isn't a very trivial one.

About inserting order_id, value and timestamp with empty address, and then searching it again to find the order_value creates problems. Let us see this case:

  1. Customer creates order and attempts pay (but doesn't select cryptocurrency)
  2. Now he gets credits via PayPal to partially pay the invoice
  3. Now if he does checkout there are two rows in DB with empty addr and it creates ambiguity on which to generate address for. If he selected say BTC in step 1, it creates another problem as now the invoice will try to pay the value of the previous order (before the credits) due to our address reuse logic

We need to think properly on designing a good way to tackle this

DarrenWestwood commented 4 years ago

About inserting order_id, value and timestamp with empty address, and then searching it again to find the order_value creates problems.

We can sort the orders by timestamp or adjust to the correct logic to reuse unused addresses for the same order, even if the amount has changed.

shivaenigma commented 4 years ago

@DarrenWestwood Please ping me on slack before taking up any further changes on this

DarrenWestwood commented 4 years ago

Found a minor issue with unconfirmed tx URL.

Fixed in 80d6956 and 6633044

TODO before release: Add link to help article here https://prnt.sc/rrbo17

Updated in c0f7d49

Remove this text: https://prnt.sc/rrbslq

Removed in d385d63

shivaenigma commented 4 years ago

Are cryptofont files used now in BCH integration ? Please remove if not used

DarrenWestwood commented 4 years ago

I think this function $scope.alt_track_url is not used anywhere anymore? (Line 64 of app.js if link does not work) https://github.com/blockonomics/whmcs-bitcoin-plugin/pull/70/files#diff-41d794d24ff042b1f9ac211fc3f9f951R64

Also this function getParameterByNameBlocko() (line 19) https://github.com/blockonomics/whmcs-bitcoin-plugin/pull/70/files#diff-41d794d24ff042b1f9ac211fc3f9f951R19

Removed with fccb919

Are cryptofont files used now in BCH integration ? Please remove if not used

Removed with 7d23e5e