blockpy-edu / blockpy

Blockly that's more Python than JavaScript, powered with Skulpt
Apache License 2.0
391 stars 130 forks source link

No feedback setting suppresses regular runtime errors #70

Closed acbart closed 3 years ago

acbart commented 4 years ago

Internally, suppressing the feedback with the relevant assignment setting suppresses all on_run code. Since the run code no longer puts anything in the feedback area, this means that those problems have no feedback. Mechanically, they should instead just give any runtime or syntax errors that occurred from run. This probably also speaks to the logging - I think we should be more ProgSnap compliant by logging those kinds of errors too.