Contract Address Pending

blockscout / blockscout

Blockchain explorer for Ethereum based network and a tool for inspecting and analyzing EVM based blockchains.

http://docs.blockscout.com

GNU General Public License v3.0

3.61k stars 2.4k forks source link

Contract Address Pending #913

Closed aristt closed 6 years ago

aristt commented 6 years ago

Describe your issue here.

Environment

Erlang/OTP 21 [erts-10.1] [source] [64-bit] [smp:1:1] [ds:1:1:10] [async-threads:1] [hipe]

Elixir 1.7.3 (compiled with Erlang/OTP 20)

Ubuntu 16.04.3 LTS

Quorum: Geth/v1.7.2-stable-99a83767/linux-amd64/go1.9.3

Consensus: IBFT

Issue

Everything seems to work fine on my Quorum environment, except

transactions showing up as not validated (but they are validated)
contract addresses not shown (instead, the label "Contract Address Pending" is shown)

Tell us what happens instead.

acravenho commented 6 years ago

Gethv1.7.2 appears to be pre-Byzantium which did not provide status fields on transactions. The only accurate method to determine a transaction status is to check for errors in the internal transactions. We currently do not support debug_tracetransaction in Geth and cannot derive the status or contract creation address.

aristt commented 6 years ago

Thanks @acravenho. The issue then will be fixed when Quorum will be rebased with Geth 1.8.

osouza-de commented 5 years ago

I'm facing this very issue with Geth 1.8.3 Istanbul network.

acravenho commented 5 years ago

@d4nd This has been resolved by #998. I'm running Geth locally with no issues currently. Can you please elaborate on what you're experiencing. There is also a PR to be merged shortly adding support for Geth internal transactions.

osouza-de commented 5 years ago

May I report this in a new issue or it's okay doing it here?

If I may:

Every transaction is: "(Awaiting internal transactions for status)"
There's a info on page header that states: " Indexing Tokens - We're indexing this chain right now. Some of the counts may be inaccurate."

But theses scenario never changes.

Im running this Geth version (1.8.3): https://github.com/getamis/go-ethereum with Istanbul BFT

acravenho commented 5 years ago

Until the internal transactions, PR (#998) is merged that message will persist. You can manually remove the message by removing the lines here:

https://github.com/poanetwork/blockscout/blob/3571c61bbeb1c09c482ca1121fa473faac4eff42/apps/block_scout_web/lib/block_scout_web/templates/layout/app.html.eex#L24-L33

osouza-de commented 5 years ago

Oh, I see. Thank you.

And about the transaction status? I'm running go-ethereum 1.8.3 and there is no transaction's status fields. EDIT: as you stated on previous comment "there's a PR to be merged" about it.

Thanks

acravenho commented 5 years ago

If you're running BlockScout on a chain that is pre-Byzantium there is no status output which is why we can't determine the status of the transaction without fetching the internal transactions :+1:

osouza-de commented 5 years ago

Thank you for point it out. I was running a chain without set the "ByzantineBlock". This solves the "Waiting internal transactions" issue.

I already got the #998 merged but the message persists on page top.

acravenho commented 5 years ago

Just have to wait for #1072 to merge and then the internal transactions will all be fetched removing this message.