Add possibility to change ERC to something else - Githubissues

blockscout / frontend

Front-end application for Blockscout

https://blockscout.com

GNU General Public License v3.0

160 stars 432 forks source link

Add possibility to change ERC to something else #1961

Closed isstuev closed 4 months ago

isstuev commented 4 months ago

Description and Related Issue(s)

resolves https://github.com/blockscout/frontend/issues/1955

Proposed Changes

added NEXT_PUBLIC_NETWORK_TOKEN_STANDARD_NAME variable to configure the display name of a token creation standard

Checklist for PR author

[x] I have tested these changes locally.
[ ] I added tests to cover any new functionality, following this guide
[ ] Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
[x] If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

isstuev commented 4 months ago

Consider adding some tests to cover new functionality.

I don't think we need tests here, the uncovered logic is only reading env from variable. all the rest is covered because even the default ERC name now comes from the config (and we have tests with token types), not from the API directly.