Fix size handling of `glTexImage2D()`

AntonioND commented 7 months ago

Currently, glTexImage2D() takes one of the values of GL_TEXTURE_SIZE_ENUM as input. There are two different issues to deal with:

This enum isn't a typedef (most enums in videoGL.h are typedefs). This is quite inconsistent, but we can live with it.
The simple fact that we need to provide weird defines to glTexImage2D() is very annoying. We should be able to pass a size in pixels and let the function do any internal handling with it as required.

My proposal:

Leave the current enum as it is, for backwards compatibility.
Modify glTexImage2D() so that it can take both. Either GL_TEXTURE_SIZE_ENUM values (which go from 0 to 7) or actual sizes in pixels (powers of two between 8 to 1024 inclusive). They don't overlap, so any program that currently works with the enum values would still work with the modified function.

rmn20 commented 7 months ago

Wow that sounds really good

AntonioND commented 7 months ago

This is a helper to convert sizes in pixels to texture enums. For now, I haven't made more changes. https://github.com/blocksds/libnds/commit/f01c830d1f00bf7559dd60c79894a37bb311e56c

AntonioND commented 7 months ago

blocksds / sdk