#23 Feature dashboard filtering

blocksights / blocksights-open-explorer

Other

5 stars 4 forks source link

#23 Feature dashboard filtering #24

Closed ihorml closed 1 year ago

ihorml commented 1 year ago

Issue #23

Description

It depends on the following backend PR: https://github.com/blocksights/graphene-insight-api/pull/5
All operations in explorer grouped into one angular component and could be filtered by account_id, asset_id, and operation_type.
To filter operations user required to click on filter icon

Also, now we have a "load more feature". Also, I decided to display a date range after first clicking on "load more". In general, it helps to understand whether you should try to load more data or not if you are looking for data for specific period

load-more

sschiessl-bcp commented 1 year ago

Very good job there! Filtering works nicely. Backend is deployed for testnet right now, so you can test by switching to it.

The current UX is

Can we do something like this or is that crazy more effort? Bascially, on click on operations you get the two first fields and on click type you get the combobox. Feels more like a "default" offering of a table

ihorml commented 1 year ago

@sschiessl-bcp it is based on <responsive-table> component released previously. It requires additional effort and custom logic, I can't surely say about the effort it requires. Maybe 2-6 hours. Does it sound good?

sschiessl-bcp commented 1 year ago

@sschiessl-bcp it is based on <responsive-table> component released previously. It requires additional effort and custom logic, I can't surely say about the effort it requires. Maybe 2-6 hours. Does it sound good?

Baking filtering into the responsive-table seems like the proper and reusable way

ihorml commented 1 year ago

@sschiessl-bcp God damn! I finished it! I did it! Tbh it wasn't easy and it took time to remember some specifics of angular-js.

So, I've prepared 2 commits for you. Please pull the latest and checkout to commit 4718755

In this commit, you will see how responsive-table filters work. Also, API doc is provided

At the latest commit, I've removed the table filters for operations-table as we agreed before. The one thing I don't know how to handle is when the user turns the filter on/off - it reloads the content even if the filter didn't apply any changes. I'll think about how to fix it but I have no ideas so far.