search

blockstrap / framework

HTML5 Crypto-Developer Framework for Bitcoin, Litecoin, Dogecoin, and DashPay
http://blockstrap.com
MIT License
90 stars 52 forks source link

Import / Export Salt Files #42

Closed CyberDexter closed 9 years ago

CyberDexter commented 9 years ago

The salt should be a downloadable file either .txt or .json perhaps. Some salts (with security question and other extra information embedded) literally freeze up notepad or crash evernote when pasted due to their length.

msmalley commented 9 years ago

@CyberLizard - Presume you agree we should have the choice of both?

Download Wallet / Download Salt

Not easy to generate file from browser using JS only. Have been unable to find a method that works consistently across browsers, not to mention having the worry of mobile. This was why we originally chose to have a copy and paste method instead. Open to further thoughts and suggestions though?

CyberDexter commented 9 years ago

I think an option to store the salt to a file at least for a desktop client would be optimal. For the wallets you can already backup the private keys inc the QR which is btw very nicely done.

I understand what you're saying though about the limitations of creating the feature. The "freezing" issue only really occurs on large salts with extensive security options selected. Not sure how to work around this. Perhaps @wdl1908 has an idea?

msmalley commented 9 years ago

@CyberLizard - One way or another, I will figure something out. Am off to Singapore to attend and present at FOSS Asia but have moved this to top of my priorities and will look into it as soon as I get back. This will give @wdl1908 some time to think about it :-)

wdl1908 commented 9 years ago

Problem solved see pull request.

CyberDexter commented 9 years ago

@wdl1908 that didn't take you long. :)

wdl1908 commented 9 years ago

I cheated coinprism has the ability to save from the browser I just went and peeked at the code and went looking for the plugin to do the same.

msmalley commented 9 years ago

@CyberLizard and @wdl1908 - have just merged the changes and added a few of my own so that people can now save either everything or just the essential base information as well as adding timestamps to the exported files. Still need a way to ensure that someone can safely export everything without overloading buffers, but may need to work on that later unless either of you think it is a critical problem that needs to be solved now?

msmalley commented 9 years ago

Will also need to test the save file functionality from mobile devices and change UX accordingly, so will not be closing this issue until that has been done too.

CyberDexter commented 9 years ago

@msmalley works fine and the export "wallet" option is great. Next challenge would be the ability to import the file in case the device was reset via the dashboard or by clearing the cache.

msmalley commented 9 years ago

Good point - my bad - forgot about the import part - will try to squeeze that into 0.5

msmalley commented 9 years ago

@CyberLizard - please note that latest master branch now allows for backup files to be imported

Please also note that we found the problem with IE, it was regarding BitcoinJS-Lib and it containing characters not valid for IE localStorage. For now, bitcoinjs-lib is forced to not be stored whilst we work on a better way of checking files prior to storing them...

CyberDexter commented 9 years ago

Awesome! We already merged it and pushed it to our platform. Keep up the great work!