search

blocktrail / slack-tipbot

Bitcoin Slack Tipbot - using BlockTrail API
https://tipbot.blocktrail.com
70 stars 33 forks source link

Not listen all messages when the bot is in private groups #5

Closed MiguelBel closed 9 years ago

MiguelBel commented 9 years ago

While testing the bot in slack I found an unexpected behavior. When it is a private group and not a public channel the bot is listening to all messages instead of responding only to the ones in which is he mentioned.

The changes are minimal but it can be nasty having the bot in a private group and he responding all messages.

More info about private groups: https://api.slack.com/types/group

rubensayshi commented 9 years ago

oh thanks, I asumed a group was considered a channel

sironitomas commented 9 years ago

Hi all.

Is this change deployed already?

On Thu, Oct 22, 2015, 06:55 Ruben de Vries notifications@github.com wrote:

oh thanks, I asumed a group was considered a channel

— Reply to this email directly or view it on GitHub https://github.com/blocktrail/slack-tipbot/pull/5#issuecomment-150165543 .

rubensayshi commented 9 years ago

yes, I deployed it yday