Stellar 01 stellar display native

blocktransfer / py-TAD3-horizon

Stock market infrastructure for the next (equitable) generation, built on Stellar.

https://tad3.dev

GNU Affero General Public License v3.0

2 stars 1 forks source link

Stellar 01 stellar display native #2

Closed defiprophecy closed 3 years ago

defiprophecy commented 3 years ago

Stellar.html now displays rather than downloading
Adding formatting for the HTML file to display the same as the linked example (https://ixinium.io/.well-known/stellar.toml)

oritwoen commented 3 years ago

I don't think that's a good solution. Parsing bots cannot read this file correctly. They will read html code and HTML tags so they won't be able to parse it as TOML.

So this is not a solution. It will display correctly, that's true, but external programs that try to read it will get errors and will not be able to download the data.

See what the sources look like:

The first is correct from the example: https://ixinium.io/.well-known/stellar.toml
This second screenshot of what your PR source code looks like.

Zrzut ekranu z 2021-07-30 22-08-16

defiprophecy commented 3 years ago

I don't think that's a good solution. Parsing bots cannot read this file correctly. They will read html code and HTML tags so they won't be able to parse it as TOML.

So this is not a solution. It will display correctly, that's true, but external programs that try to read it will get errors and will not be able to download the data.

See what the sources look like:

The first is correct from the example: https://ixinium.io/.well-known/stellar.toml

This second screenshot of what your PR source code looks like.

Thanks for the comment and review, this is my first time doing stellar files on github pages :) I'm looking into this, I've changed the content type to 'text/plain; charset=UTF-8", still trying to figure the rest out

JFWooten4 commented 3 years ago

I don't think that's a good solution. Parsing bots cannot read this file correctly. They will read html code and HTML tags so they won't be able to parse it as TOML. So this is not a solution. It will display correctly, that's true, but external programs that try to read it will get errors and will not be able to download the data. See what the sources look like:

The first is correct from the example: https://ixinium.io/.well-known/stellar.toml

This second screenshot of what your PR source code looks like.

Thanks for the comment and review, this is my first time doing stellar files on github pages :) I'm looking into this, I've changed the content type to 'text/plain; charset=UTF-8", still trying to figure the rest out

This is precisely right, as this file is mostly for parsing anyway. Thank you both for the contributions.