Server: save backups in ANSI format

blocktronics / moebius

Modern ANSI & ASCII Art Editor

https://blocktronics.github.io/moebius/

Apache License 2.0

756 stars 41 forks source link

Server: save backups in ANSI format #138

Closed bart-d closed 4 years ago

bart-d commented 4 years ago

Save the server hourly backups in ANSI format instead of a comma separated list of ASCII codes.

andyherbert commented 4 years ago

This is odd, I just tried and it appears to be ansi format. Are there any particular sequence that appear comma separated?

bart-d commented 4 years ago

it's the entire file, numeric ASCII codes comma separated. I've attached an example ( server1588464045.zip). This is the most recent backup of the Moebius server on 16c (visible here: https://16colo.rs/servers/)

I convert it back to ANSI through splitting by comma and doing a chr on every value.

andyherbert commented 4 years ago

That's strange. I saved the 16c server session locally and used it as a server session myself and the backup still saved as expected. I've pushed a change to explicitly save bytes in binary representation. If you can reproduce this bug then I'd be grateful if you can try this change.

bart-d commented 4 years ago

Yes, even with the patch I can reproduce it. Started out with an empty file. Haven't tried on any other OS than Linux though.

bart-d commented 4 years ago

works fine on MacOS apparently

andyherbert commented 4 years ago

Are the versions of node on both platforms identical?

bart-d commented 4 years ago

Are the versions of node on both platforms identical?

v8.10.0 on Linux vs. v12.16.2 on MacOS. I'll try upgrading node on Linux.

bart-d commented 4 years ago

upgrading to node v12 fixes the issue. thanks! :)